Re: [PATCH 1/3] x86, msr: add rd/wrmsr interfaces with preset registers

Andrew Morton
2009-09-03T23:15:29Z

On Thu, 03 Sep 2009 15:57:54 -0700
"H. Peter Anvin" <hpa@zytor.com> wrote:

> On 09/03/2009 03:55 PM, Andrew Morton wrote:
> > On Mon, 31 Aug 2009 09:50:09 +0200
> > Borislav Petkov <petkovbb@googlemail.com> wrote:
> >
> >> +.macro op_safe_regs op:req
> >
> > Using
> >
> > GNU assembler 2.16.1
> >
> > I get
> >
> > arch/x86/lib/msr-reg.S: Assembler messages:
> > arch/x86/lib/msr-reg.S:53: Error: Bad macro parameter list
> > arch/x86/lib/msr-reg.S:100: Error: invalid character '_' in mnemonic
> > arch/x86/lib/msr-reg.S:101: Error: invalid character '_' in mnemonic
> >
> > this:
> >
> > diff -puN arch/x86/lib/msr-reg.S~a arch/x86/lib/msr-reg.S
> > --- a/arch/x86/lib/msr-reg.S~a
> > +++ a/arch/x86/lib/msr-reg.S
> > @@ -50,7 +50,7 @@ ENDPROC(native_\op\()_safe_regs)
> >
> > #else /* X86_32 */
> >
> > -.macro op_safe_regs op:req
> > +.macro op_safe_regs op
> > ENTRY(native_\op\()_safe_regs)
> > CFI_STARTPROC
> > pushl_cfi %ebx
> >
> >
> > fixed it.
>
> Yup, already fixed in -tip.
>

<looks>

Three days ago. linux-next is still busted.

I want my five minutes back.