Re: [tip:x86/urgent] x86, AMD: Disable wrongly set X86_FEATURE_LAHF_LM CPUID bit

H. Peter Anvin
2009-08-25T06:45:32Z

On 08/24/2009 10:52 PM, Borislav Petkov wrote:
> On Mon, Aug 24, 2009 at 01:34:07PM -0700, H. Peter Anvin wrote:
>> Looks reasonable... although part of me wonders if having a pointer to
>> an array containing the entire register file in and out is even better,
>> of if I'm just overengineering at this point.
>
> Hmm, let's have necessity determine that. I can only think of %edi being
> used as an input reg to rd/wrmsr beside %ecx but it could be very well
> that some other x86 hardware uses other regs too. Do we actually need
> all regs or a two should suffice?
>

Hard to know. In theory we shouldn't need ESI and EDI either!

As I said, I wouldn't have worried about it at all if it wasn't for
paravirt_ops turning these things into ABIs.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.