Re: [PATCH] PM: kill dev_pm_ops platform warning for now

Re: [PATCH] PM: kill dev_pm_ops platform warning for now

[Rafael J. Wysocki]

On Friday 07 August 2009, Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
> 
> Remove the platform device runtime dev_pm_ops warning
> for now. No point in upsetting users of non-rc kernels.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

Thanks for the patch, I modified the changelog a bit.

Greg, do you agree with the patch below?

Rafael

---
From: Magnus Damm <damm@igel.co.jp>
Subject: PM / Driver Core: Kill dev_pm_ops platform warning for now

Commit 783ea7d4eeefe895f2731fe73ac951e94418927b
(Driver Core: Rework platform suspend/resume, print warning)
added a warning message printed for platform drivers that use the
legacy PM callbacks rather than struct dev_pm_ops.  Unfortunately,
this resulted in some confusion and made some people try to convert
drivers by replacing the old callbacks with struct dev_pm_ops in
automatic way, which generally is not a good idea.

Remove the platform device runtime dev_pm_ops warning for now,
because it's annoying to users and it's not really necessary right
now.

[rjw: Modified the changelog to be more informative.]

Signed-off-by: Magnus Damm <damm@igel.co.jp>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/base/platform.c |    3 ---
 1 file changed, 3 deletions(-)

Index: linux-2.6/drivers/base/platform.c
===================================================================
--- linux-2.6.orig/drivers/base/platform.c
+++ linux-2.6/drivers/base/platform.c
@@ -483,9 +483,6 @@ int platform_driver_register(struct plat
 		drv->driver.remove = platform_drv_remove;
 	if (drv->shutdown)
 		drv->driver.shutdown = platform_drv_shutdown;
-	if (drv->suspend || drv->resume)
-		pr_warning("Platform driver '%s' needs updating - please use "
-			"dev_pm_ops\n", drv->driver.name);
 
 	return driver_register(&drv->driver);
 }

Re: [PATCH] PM: kill dev_pm_ops platform warning for now

[Greg KH]

On Sat, Aug 08, 2009 at 03:16:23PM +0200, Rafael J. Wysocki wrote:
> On Friday 07 August 2009, Magnus Damm wrote:
> > From: Magnus Damm <damm@igel.co.jp>
> > 
> > Remove the platform device runtime dev_pm_ops warning
> > for now. No point in upsetting users of non-rc kernels.
> > 
> > Signed-off-by: Magnus Damm <damm@igel.co.jp>
> 
> Thanks for the patch, I modified the changelog a bit.
> 
> Greg, do you agree with the patch below?

Yes, feel free to add:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to the patch and forward it on.

Or do you need me to forward it?

thanks,

greg k-h

Re: [PATCH] PM: kill dev_pm_ops platform warning for now

[Rafael J. Wysocki]

On Monday 10 August 2009, Greg KH wrote:
> On Sat, Aug 08, 2009 at 03:16:23PM +0200, Rafael J. Wysocki wrote:
> > On Friday 07 August 2009, Magnus Damm wrote:
> > > From: Magnus Damm <damm@igel.co.jp>
> > > 
> > > Remove the platform device runtime dev_pm_ops warning
> > > for now. No point in upsetting users of non-rc kernels.
> > > 
> > > Signed-off-by: Magnus Damm <damm@igel.co.jp>
> > 
> > Thanks for the patch, I modified the changelog a bit.
> > 
> > Greg, do you agree with the patch below?
> 
> Yes, feel free to add:
> 	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> to the patch and forward it on.
> 
> Or do you need me to forward it?

If you have anything more to push to Linus, please push this patch along with
it with my ACK.  Otherwise, please let me know and I'll push it.

Thanks,
Rafael

Re: [PATCH] PM: kill dev_pm_ops platform warning for now

[Greg KH]

On Mon, Aug 10, 2009 at 10:49:12PM +0200, Rafael J. Wysocki wrote:
> On Monday 10 August 2009, Greg KH wrote:
> > On Sat, Aug 08, 2009 at 03:16:23PM +0200, Rafael J. Wysocki wrote:
> > > On Friday 07 August 2009, Magnus Damm wrote:
> > > > From: Magnus Damm <damm@igel.co.jp>
> > > > 
> > > > Remove the platform device runtime dev_pm_ops warning
> > > > for now. No point in upsetting users of non-rc kernels.
> > > > 
> > > > Signed-off-by: Magnus Damm <damm@igel.co.jp>
> > > 
> > > Thanks for the patch, I modified the changelog a bit.
> > > 
> > > Greg, do you agree with the patch below?
> > 
> > Yes, feel free to add:
> > 	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> > to the patch and forward it on.
> > 
> > Or do you need me to forward it?
> 
> If you have anything more to push to Linus, please push this patch along with
> it with my ACK.  Otherwise, please let me know and I'll push it.

I do not have any more driver-core changes to push to Linus for 2.6.31,
so please send it with your next push.

thanks,

greg k-h