Re: [patch 2/5] Staging: vme: add VME userspace driver

Emilio G. Cota
2009-08-10T20:36:49Z

Martyn Welch wrote:
> Emilio G. Cota wrote:
>> Martyn Welch wrote:
>> The point here is that the driver should know *nothing* about
>> windows, etc. What it should just know is:
>> - I want a mapping of a certain size to VME address X
>>
>
> I'm not convinced. Given that each bridge provides a limited number of
> windows (some more than others), we are limited to how large a window we
> can produce (we need to map them somewhere) and the potential
> combinations are so great (independant 16, 32, 40, 64 and CR/CSR address
> spaces, not to mention access modes) it is important to assign the
> windows to a driver, so that it may move them as it sees fit. For
> example, supporting 10 devices (as you have mentioned earier) with a
> single driver could potentially require a single window that it knows it
> has exclusive use of to position over each devices register as required
> without either having to provide a large window (unfeasibly large on
> most/all platforms if they are scattered across the 64-bit address
> space) or needing more windows than are available on any of the bridges
> I have seen (8 being the maximum).

No, it corresponds to the bridge to manage *its* resources. Drivers
would have a very hard time, because they'd need to know their
own resources but _also_ the use other drivers are making of the
bridge. And that's madness at its best.

>> The struct provides exactly this.
>>
> Ah - vme_dma does to some degree. I was talking about vme_mapping for
> configuring vme windows, from your vmebus.h:
>

[ was it just me or some lines + links got copied? I've removed them
anyway ]

> * This data structure is used for describing both a hardware window
> * and a logical mapping on top of a hardware window. Therefore some of
> * the fields are only relevant to one of those two entities.
> */
> struct vme_mapping {
> int window_num;
>

[ snip ]
> enum vme_read_prefetch_size read_prefetch_size;
> Tsi-148 specific.

If others don't implement it, it's ok; however you need to
cover all the cases, so it's needed here.

[ snip ]
> int bcast_select;
> unsigned int pci_addru;
> unsigned int pci_addrl;
>
> Why are these split, why not a single unsigned long long?
> unsigned int sizeu;
> unsigned int sizel;
> Ditto.
> unsigned int vme_addru;
> unsigned int vme_addrl;
> Ditto.

- Most accesses are 32-bit accesses. Treating all of them
as 64-bit accesses would decrease performance for most of
them--which happen to be 32-bit.

> In addition your enum vme_address_modifier would need extending when
> specifying slave windows, the tsi-148 can support windows with USER and
> SUP access, as well as DATA and PRG. Why throw access privileges and
> address spaces together like that? The VME spec also specifies 4 User
> definable address spaces...

Well Sebastien worked on this for less than two months, and to be
honest with you the result is much better than the original code
we had from Motorola--which is the one you based your work on,
I think.
So yes, the whole spec is not there, but
- If no one uses something, there's no point in implementing it--
irrespective of being written on a spec or not.
- Sebastien did a bloody good job, but obviously he focused on
our urgent matters, i.e. with the Motorola driver we couldn't
go on production with our machines.

> I'm still not convinced by all these structures - you've defined tonnes
> of them, I don't feel that it aids readability and maintainability at
> all.
Tons of them? Seriously?

t61$ /data/src/linux-next/include/linux ->cat pci*.h | egrep '^struct' | wc -l
41
t61$ /data/src/linux-next/include/linux ->cat vme*.h | egrep '^struct' | wc -l
6

I would call that pretty sane as a starting point.

[ NB. this is my current dev tree, vme.h is just 'our' vmebus.h
Lynx's compatility crap removed ]

> It's all over the web :-) We've had it for years and I'm not sure under
> what terms we originally got it, so I'm afraid I've got to assume we're
> still bound under some NDA, sorry. Searching google for "Universe II
> Manual" much get you what you want though...

o rite, no probs.

Thanks,
E.