public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org,
	Neil Horman <nhorman@redhat.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andi Kleen <andi@firstfloor.org>,
	Amerigo Wang <amwang@redhat.com>,
	akpm@linux-foundation.org, bernhard.walle@gmx.de,
	Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
	Anton Vorontsov <avorontsov@ru.mvista.com>
Subject: [Patch 8/8] kexec: allow to shrink reserved memory
Date: Wed, 12 Aug 2009 04:16:44 -0400	[thread overview]
Message-ID: <20090812081906.5757.39417.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090812081731.5757.25254.sendpatchset@localhost.localdomain>

This patch implements shrinking the reserved memory for crash kernel,
if it is more than enough.

For example, if you have already reserved 128M, now you just want 100M,
you can do:

# echo $((100*1024*1024)) > /sys/kernel/kexec_crash_size

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Neil Horman <nhorman@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Andi Kleen <andi@firstfloor.org>

---

Index: linux-2.6/include/linux/kexec.h
===================================================================
--- linux-2.6.orig/include/linux/kexec.h
+++ linux-2.6/include/linux/kexec.h
@@ -206,6 +206,9 @@ extern size_t vmcoreinfo_max_size;
 
 int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
 		unsigned long long *crash_size, unsigned long long *crash_base);
+int shrink_crash_memory(unsigned long new_size);
+int kexec_crash_kernel_loaded(void);
+size_t get_crash_memory_size(void);
 
 #else /* !CONFIG_KEXEC */
 struct pt_regs;
Index: linux-2.6/kernel/kexec.c
===================================================================
--- linux-2.6.orig/kernel/kexec.c
+++ linux-2.6/kernel/kexec.c
@@ -1083,6 +1083,76 @@ void crash_kexec(struct pt_regs *regs)
 	}
 }
 
+int kexec_crash_kernel_loaded(void)
+{
+	int ret;
+	if (!mutex_trylock(&kexec_mutex))
+		return 1;
+	ret = kexec_crash_image != NULL;
+	mutex_unlock(&kexec_mutex);
+	return ret;
+}
+
+size_t get_crash_memory_size(void)
+{
+	size_t size;
+	if (!mutex_trylock(&kexec_mutex))
+		return 1;
+	size = crashk_res.end - crashk_res.start + 1;
+	mutex_unlock(&kexec_mutex);
+	return size;
+}
+
+int shrink_crash_memory(unsigned long new_size)
+{
+	struct page **pages;
+	int ret = 0;
+	int  npages, i;
+	unsigned long addr;
+	unsigned long start, end;
+	void *vaddr;
+
+	if (!mutex_trylock(&kexec_mutex))
+		return -EBUSY;
+
+	start = crashk_res.start;
+	end = crashk_res.end;
+
+	if (new_size >= end - start + 1) {
+		ret = -EINVAL;
+		if (new_size == end - start + 1)
+			ret = 0;
+		goto unlock;
+	}
+
+	start = roundup(start, PAGE_SIZE);
+	end = roundup(start + new_size, PAGE_SIZE) - 1;
+	npages = (end + 1 - start ) / PAGE_SIZE;
+
+	pages = kmalloc(sizeof(struct page *) * npages, GFP_KERNEL);
+	if (!pages) {
+		ret = -ENOMEM;
+		goto unlock;
+	}
+	for (i = 0; i < npages; i++) {
+		addr = end + 1 + i * PAGE_SIZE;
+		pages[i] = virt_to_page(addr);
+	}
+
+	vaddr = vm_map_ram(pages, npages, 0, PAGE_KERNEL);
+	if (!vaddr) {
+		ret = -ENOMEM;
+		goto free;
+	}
+	crashk_res.end = end;
+
+free:
+	kfree(pages);
+unlock:
+	mutex_unlock(&kexec_mutex);
+	return ret;
+}
+
 static u32 *append_elf_note(u32 *buf, char *name, unsigned type, void *data,
 			    size_t data_len)
 {
Index: linux-2.6/kernel/ksysfs.c
===================================================================
--- linux-2.6.orig/kernel/ksysfs.c
+++ linux-2.6/kernel/ksysfs.c
@@ -100,6 +100,26 @@ static ssize_t kexec_crash_loaded_show(s
 }
 KERNEL_ATTR_RO(kexec_crash_loaded);
 
+static ssize_t kexec_crash_size_show(struct kobject *kobj,
+				       struct kobj_attribute *attr, char *buf)
+{
+	return sprintf(buf, "%lu\n", get_crash_memory_size());
+}
+static ssize_t kexec_crash_size_store(struct kobject *kobj,
+				   struct kobj_attribute *attr,
+				   const char *buf, size_t count)
+{
+	unsigned long cnt;
+	int ret;
+
+	if (kexec_crash_kernel_loaded())
+		return -ENOENT;
+	cnt = simple_strtoul(buf, NULL, 10);
+	ret = shrink_crash_memory(cnt);
+	return ret < 0 ? ret: count;
+}
+KERNEL_ATTR_RW(kexec_crash_size);
+
 static ssize_t vmcoreinfo_show(struct kobject *kobj,
 			       struct kobj_attribute *attr, char *buf)
 {
@@ -147,6 +167,7 @@ static struct attribute * kernel_attrs[]
 #ifdef CONFIG_KEXEC
 	&kexec_loaded_attr.attr,
 	&kexec_crash_loaded_attr.attr,
+	&kexec_crash_size_attr.attr,
 	&vmcoreinfo_attr.attr,
 #endif
 	NULL

  parent reply	other threads:[~2009-08-12  8:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12  8:15 [Patch 0/8] V3 Implement crashkernel=auto Amerigo Wang
2009-08-12  8:15 ` [Patch 1/8] x86: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-12  8:15 ` [Patch 2/8] x86: implement crashkernel=auto Amerigo Wang
2009-08-12  8:15 ` [Patch 3/8] ia64: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-12  8:15 ` [Patch 4/8] ia64: implement crashkernel=auto Amerigo Wang
2009-08-12  8:16 ` [Patch 5/8] powerpc: add CONFIG_KEXEC_AUTO_RESERVE Amerigo Wang
2009-08-12  8:16 ` [Patch 6/8] powerpc: implement crashkernel=auto Amerigo Wang
2009-08-12  8:16 ` [Patch 7/8] doc: update the kdump document Amerigo Wang
2009-08-12  8:16 ` Amerigo Wang [this message]
2009-08-13  3:11   ` [Patch 8/8] kexec: allow to shrink reserved memory Eric W. Biederman
2009-08-13  3:32     ` Amerigo Wang
2009-08-13  6:18       ` Eric W. Biederman
2009-08-13  8:23         ` Amerigo Wang
2009-08-14 22:17           ` Eric W. Biederman
2009-08-17  9:50             ` Amerigo Wang
2009-08-18  0:29               ` KAMEZAWA Hiroyuki
2009-08-18  6:31                 ` Amerigo Wang
2009-08-18  8:25                   ` KAMEZAWA Hiroyuki
2009-08-18  8:51                     ` Amerigo Wang
2009-08-18 10:35                     ` Amerigo Wang
2009-08-18 23:57                       ` KAMEZAWA Hiroyuki
2009-08-19  2:41                         ` Amerigo Wang
2009-08-19  8:13                           ` KAMEZAWA Hiroyuki
2009-08-19 10:47                             ` Amerigo Wang
2009-08-20  9:15                             ` Amerigo Wang
2009-08-21  0:34                               ` KAMEZAWA Hiroyuki
2009-08-21  1:59                                 ` Amerigo Wang
2009-08-21  2:03                                   ` KAMEZAWA Hiroyuki
2009-08-21  2:47                                     ` Amerigo Wang
2009-08-12 12:46 ` [Patch 0/8] V3 Implement crashkernel=auto Bernhard Walle
2009-08-13  2:49   ` Amerigo Wang
2009-08-13  5:39     ` Bernhard Walle
2009-08-13  8:19       ` Amerigo Wang
2009-08-13  9:03         ` Bernhard Walle
2009-08-13 10:49           ` Eric W. Biederman
2009-08-14  2:59             ` Amerigo Wang
  -- strict thread matches above, loose matches on Subject: below --
2009-08-27  3:15 [Patch 0/8] V5 " Amerigo Wang
2009-08-27  3:17 ` [Patch 8/8] kexec: allow to shrink reserved memory Amerigo Wang
2009-09-04 10:08 [Patch 0/8] V6 Implement crashkernel=auto Amerigo Wang
2009-09-04 10:09 ` [Patch 8/8] kexec: allow to shrink reserved memory Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090812081906.5757.39417.sendpatchset@localhost.localdomain \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=bernhard.walle@gmx.de \
    --cc=ebiederm@xmission.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nhorman@redhat.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox