From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Michael Barkowski <michaelbarkowski@ruggedcom.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ben Dooks <ben@fluff.org>,
David Brownell <dbrownell@users.sourceforge.net>,
David Woodhouse <dwmw2@infradead.org>,
Grant Likely <grant.likely@secretlab.ca>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jean Delvare <khali@linux-fr.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching
Date: Thu, 13 Aug 2009 00:58:00 +0400 [thread overview]
Message-ID: <20090812205800.GA27074@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4A832A03.6020507@ruggedcom.com>
On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote:
> Hello Anton,
>
> Is m25p_probe now valid with dev.platform_data == NULL, for of platforms?
>
> Then shouldn't you have the following change as well, near the end of
> the function?
>
> - } else if (data->nr_parts)
> + } else if (data && data->nr_parts)
> dev_warn(&spi->dev, "ignoring %d default partitions on %s\n",
> data->nr_parts, data->name);
>
> Or am I misunderstanding something?
Yeah, you missed this patch:
http://patchwork.kernel.org/patch/38179/
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-08-12 20:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 0:39 [PATCH v2 0/6] Device table matching for SPI subsystem Anton Vorontsov
2009-07-31 0:40 ` [PATCH 1/6] spi: Add support for device table matching Anton Vorontsov
2009-07-31 0:41 ` [PATCH 2/6] mtd: m25p80: Convert to " Anton Vorontsov
2009-08-04 2:54 ` David Brownell
2009-08-18 21:44 ` Anton Vorontsov
2009-08-18 21:46 ` [PATCH 1/2] mtd: m25p80: Rework probing/JEDEC code Anton Vorontsov
2010-06-12 6:27 ` Barry Song
2010-06-18 13:32 ` Anton Vorontsov
2010-06-21 2:42 ` [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code Song, Barry
2010-06-21 3:27 ` Barry Song
2010-06-21 7:15 ` Anton Vorontsov
2010-06-21 7:22 ` Barry Song
2010-06-21 7:39 ` Anton Vorontsov
2010-06-21 10:31 ` Barry Song
2010-06-21 11:20 ` Anton Vorontsov
2010-06-21 16:34 ` Mike Frysinger
2010-06-21 16:47 ` Anton Vorontsov
2010-06-21 16:54 ` Mike Frysinger
2010-06-22 6:37 ` Barry Song
2010-06-22 16:55 ` Anton Vorontsov
2010-06-22 16:57 ` [PATCH 1/2] mtd: m25p80: Fix false-positive probing Anton Vorontsov
2010-06-22 17:56 ` Mike Frysinger
2010-07-08 5:57 ` Artem Bityutskiy
2010-06-22 16:57 ` [PATCH 2/2] mtd: m25p80: Make jedec_probe() return proper errno values Anton Vorontsov
2009-08-18 21:46 ` [PATCH 2/2] mtd: m25p80: Add support for CAT25xxx serial EEPROMs Anton Vorontsov
2009-09-22 23:25 ` Andrew Morton
2009-09-22 23:40 ` Anton Vorontsov
2009-09-22 21:17 ` [PATCH 2/6] mtd: m25p80: Convert to device table matching Andrew Morton
2009-09-22 23:01 ` Anton Vorontsov
2009-09-22 23:43 ` David Woodhouse
2009-09-22 23:52 ` Andrew Morton
2009-09-22 23:55 ` Anton Vorontsov
2009-09-23 0:02 ` Andrew Morton
2009-08-12 20:45 ` Michael Barkowski
2009-08-12 20:58 ` Anton Vorontsov [this message]
2009-08-12 20:58 ` Michael Barkowski
2009-07-31 0:41 ` [PATCH 3/6] of: Remove "stm,m25p40" alias Anton Vorontsov
2009-07-31 0:41 ` [PATCH 4/6] hwmon: adxx: Convert to device table matching Anton Vorontsov
2009-07-31 0:41 ` [PATCH 5/6] hwmon: lm70: " Anton Vorontsov
2009-07-31 0:41 ` [PATCH 6/6] spi: Prefix modalias with "spi:" Anton Vorontsov
2009-08-10 7:35 ` [PATCH v2 0/6] Device table matching for SPI subsystem Artem Bityutskiy
2009-08-18 21:44 ` Anton Vorontsov
2009-08-25 14:14 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812205800.GA27074@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=ben@fluff.org \
--cc=benh@kernel.crashing.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
--cc=michaelbarkowski@ruggedcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).