From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
stephane eranian <eranian@googlemail.com>
Cc: Corey J Ashford <cjashfor@us.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 3/4] perf tools: Add some comments to the event definitions
Date: Thu, 13 Aug 2009 11:47:55 +0200 [thread overview]
Message-ID: <20090813103655.334194326@chello.nl> (raw)
In-Reply-To: 20090813094752.433445710@chello.nl
[-- Attachment #1: perf-tools-fix-read.patch --]
[-- Type: text/plain, Size: 814 bytes --]
Just to make it clear that these are _not_ generic event structures
but do rely on the counter configuration.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
tools/perf/util/event.h | 6 ++++++
1 file changed, 6 insertions(+)
Index: linux-2.6/tools/perf/util/event.h
===================================================================
--- linux-2.6.orig/tools/perf/util/event.h
+++ linux-2.6/tools/perf/util/event.h
@@ -4,6 +4,9 @@
#include "util.h"
#include <linux/list.h>
+/*
+ * PERF_SAMPLE_IP | PERF_SAMPLE_TID | *
+ */
struct ip_event {
struct perf_event_header header;
u64 ip;
@@ -38,6 +41,9 @@ struct lost_event {
u64 lost;
};
+/*
+ * PERF_FORMAT_ENABLED | PERF_FORMAT_RUNNING | PERF_FORMAT_ID
+ */
struct read_event {
struct perf_event_header header;
u32 pid,tid;
--
next prev parent reply other threads:[~2009-08-13 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 9:47 [PATCH 0/4] perf_counter: Group reads and other patches Peter Zijlstra
2009-08-13 9:47 ` [PATCH 1/4 -v2] perf: rework the whole read vs group stuff Peter Zijlstra
2009-08-13 11:00 ` [tip:perfcounters/urgent] perf: Rework/fix " tip-bot for Peter Zijlstra
2009-08-21 14:47 ` [PATCH 1/4 -v2] perf: rework " stephane eranian
2009-08-21 15:19 ` Peter Zijlstra
2009-08-21 19:36 ` [tip:perfcounters/urgent] perf_counter: Fix typo in read() output generation tip-bot for Peter Zijlstra
2009-08-13 9:47 ` [PATCH 2/4] perf_counter: Fix an ipi-deadlock Peter Zijlstra
2009-08-13 11:00 ` [tip:perfcounters/urgent] " tip-bot for Peter Zijlstra
2009-08-13 9:47 ` Peter Zijlstra [this message]
2009-08-13 11:01 ` [tip:perfcounters/core] perf tools: Add some comments to the event definitions tip-bot for Peter Zijlstra
2009-08-15 10:07 ` tip-bot for Peter Zijlstra
2009-08-13 9:47 ` [PATCH 4/4] perf_counter: Fix swcounter context invariance Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813103655.334194326@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=cjashfor@us.ibm.com \
--cc=eranian@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox