public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, Oren Laadan <orenl@cs.columbia.edu>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
	torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
	hpa@zytor.com, Containers <containers@lists.linux-foundation.org>,
	sukadev@us.ibm.com, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [RFC][v4][PATCH 0/7] clone_with_pids() system call
Date: Thu, 13 Aug 2009 08:32:56 -0500	[thread overview]
Message-ID: <20090813133256.GA30731@us.ibm.com> (raw)
In-Reply-To: <m1vdks5qc8.fsf@fess.ebiederm.org>

Quoting Eric W. Biederman (ebiederm@xmission.com):
> Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes:
> 
> > === NEW CLONE() SYSTEM CALL:
> >
> > To support application checkpoint/restart, a task must have the same pid it
> > had when it was checkpointed.  When containers are nested, the tasks within
> > the containers exist in multiple pid namespaces and hence have multiple pids
> > to specify during restart.
> >
> > This patchset implements a new system call, clone_with_pids() that lets a
> > process specify the pids of the child process.
> >
> > Patches 1 through 5 are helpers and we believe they are needed for application
> > restart, regardless of the kernel implementation of application restart.
> 
> I'm not very impressed.
> 
> - static int alloc_pidmap(struct pid_namespace *pid_ns)
> + static int alloc_pidmap(struct pid_namespace *pid_ns, int pid_max, int last_pid)

Regardless of Suka's patch, note that I did send you a patch back on march 21
to make pid_max a pidns property.  I suspect that's still something we
want. 

-serge

      parent reply	other threads:[~2009-08-13 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07  6:11 [RFC][v4][PATCH 0/7] clone_with_pids() system call Sukadev Bhattiprolu
2009-08-07  6:12 ` [RFC][v4][PATCH 1/7]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-08-07  6:12 ` [RFC][v4][PATCH 2/7]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-08-07  6:13 ` [RFC][v4][PATCH 3/7]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-08-07  6:13 ` [RFC][v4][PATCH 4/7]: Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-08-07  6:13 ` [RFC][v4][PATCH 5/7]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-08-07  6:14 ` [RFC][v4][PATCH 6/7]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-08-07  6:15 ` [RFC][v4][PATCH 7/7]: Define clone_with_pids syscall Sukadev Bhattiprolu
2009-08-10 14:54   ` Pavel Machek
2009-08-10 15:07     ` Serge E. Hallyn
2009-08-10 22:26     ` Sukadev Bhattiprolu
2009-08-13  3:45 ` [RFC][v4][PATCH 0/7] clone_with_pids() system call Eric W. Biederman
2009-08-13  8:00   ` Sukadev Bhattiprolu
2009-08-13  9:05     ` Eric W. Biederman
2009-08-13 19:46       ` Serge E. Hallyn
2009-08-21 16:11         ` Serge E. Hallyn
2009-08-18  3:31       ` Sukadev Bhattiprolu
2009-08-13 13:32   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090813133256.GA30731@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=orenl@cs.columbia.edu \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=sukadev@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox