Re: [RFC patch 2/3] genirq: Add buslock support for irq chips on slow busses

[Pavel Machek <pavel@ucw.cz>]

Hi!

> Index: linux-2.6-tip/include/linux/interrupt.h
> ===================================================================
> --- linux-2.6-tip.orig/include/linux/interrupt.h
> +++ linux-2.6-tip/include/linux/interrupt.h
> @@ -113,6 +113,11 @@ request_threaded_irq(unsigned int irq, i
>  		     irq_handler_t thread_fn,
>  		     unsigned long flags, const char *name, void *dev);
>  
> +extern int __must_check
> +request_threaded_slowbus_irq(unsigned int irq, irq_handler_t handler,
> +			     irq_handler_t thread_fn,
> +			     unsigned long flags, const char *name, void *dev);
> +
>  static inline int __must_check
>  request_irq(unsigned int irq, irq_handler_t handler, unsigned long flags,
>  	    const char *name, void *dev)
> @@ -145,6 +150,7 @@ static inline void exit_irq_thread(void)
>  #endif
>  
>  extern void free_irq(unsigned int, void *);
> +extern void free_slowbus_irq(unsigned int irq, void *dev_id);
>  
>  struct device;
>  
> @@ -186,6 +192,9 @@ extern void disable_irq_nosync(unsigned 
>  extern void disable_irq(unsigned int irq);
>  extern void enable_irq(unsigned int irq);
>  
> +extern void disable_slowbus_irq(unsigned int irq);
> +extern void enable_slowbus_irq(unsigned int irq);
> +

AFAICT this means that driver would need to know what kind of IRQ it
is hooked to, right? That will lead to some ugly code in drivers that
can handle both normal and slowbus irqs, right?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html