From: Greg KH <gregkh@suse.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] icom: bit and/or confusion?
Date: Fri, 14 Aug 2009 08:50:04 -0700 [thread overview]
Message-ID: <20090814155004.GA10977@suse.de> (raw)
In-Reply-To: <4A85525A.9030601@gmail.com>
On Fri, Aug 14, 2009 at 02:02:34PM +0200, Roel Kluin wrote:
> Previously, if any bit other than CMD_SND_BREAK was set, CMD_SND_BREAK
> was not unset.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I think meant was: If CMD_SND_BREAK is set, unset it. Correct?
>
> // vi drivers/serial/icom.h +137
> #define CMD_SND_BREAK 0x04
>
> diff --git a/drivers/serial/icom.c b/drivers/serial/icom.c
> index cd1b6a4..060f4e3 100644
> --- a/drivers/serial/icom.c
> +++ b/drivers/serial/icom.c
> @@ -617,7 +617,7 @@ static void shutdown(struct icom_port *icom_port)
> * disable break condition
> */
> cmdReg = readb(&icom_port->dram->CmdReg);
> - if ((cmdReg | CMD_SND_BREAK) == CMD_SND_BREAK) {
> + if (cmdReg & CMD_SND_BREAK) {
This change is the exact same thing, right? How is the original
incorrect here?
thanks,
greg k-h
next prev parent reply other threads:[~2009-08-14 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 12:02 [PATCH] icom: bit and/or confusion? Roel Kluin
2009-08-14 15:50 ` Greg KH [this message]
2009-08-14 17:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814155004.GA10977@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox