From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Valdis.Kletnieks@vt.edu
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH tip 1/1] perf record: Fix typo in pid_synthesize_comm_event
Date: Fri, 14 Aug 2009 17:10:48 -0300 [thread overview]
Message-ID: <20090814201048.GG3490@ghostprotocols.net> (raw)
In-Reply-To: <28379.1250276831@turing-police.cc.vt.edu>
Em Fri, Aug 14, 2009 at 03:07:11PM -0400, Valdis.Kletnieks@vt.edu escreveu:
> On Fri, 14 Aug 2009 15:26:32 -0300, Arnaldo Carvalho de Melo said:
> > We were using 'fd' locally, but there was a global 'fd' too, so when
> > converting from open to fopen the test made against fd should be made
> > against 'fp', but since we have that global...
>
> If the kernel was -Wshadow safe by default, this sort of thing would happen
> less often... :)
I would love to have that kind of problem spotted by the compiler, but
this is no kernel code, the CFLAGS we use is different than the kernel
ones, I guess a patch for tools/perf/ would be gladly accepted by Ingo,
but let him say so :-)
- Arnaldo
next prev parent reply other threads:[~2009-08-14 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 18:26 [PATCH tip 1/1] perf record: Fix typo in pid_synthesize_comm_event Arnaldo Carvalho de Melo
2009-08-14 19:07 ` Valdis.Kletnieks
2009-08-14 20:10 ` Arnaldo Carvalho de Melo [this message]
2009-08-15 9:56 ` Ingo Molnar
2009-08-15 10:06 ` [tip:perfcounters/urgent] " tip-bot for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814201048.GG3490@ghostprotocols.net \
--to=acme@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox