From: Ingo Molnar <mingo@elte.hu>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemleak: Ignore the aperture memory hole on x86_64
Date: Sun, 16 Aug 2009 12:08:20 +0200 [thread overview]
Message-ID: <20090816100820.GA26474@elte.hu> (raw)
In-Reply-To: <1250290118.5085.21.camel@pc1117.cambridge.arm.com>
* Catalin Marinas <catalin.marinas@arm.com> wrote:
> This block is allocated with alloc_bootmem() and scanned by kmemleak but
> the kernel direct mapping may no longer exist. This patch tells kmemleak
> to ignore this memory hole.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/aperture_64.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index 676debf..cb690b3 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -94,6 +94,11 @@ static u32 __init allocate_aperture(void)
> * code for safe
> */
> p = __alloc_bootmem_nopanic(aper_size, aper_size, 512ULL<<20);
> + /*
> + * Kmemleak should not scan this block as it may not be mapped via the
> + * kernel direct mapping.
> + */
> + kmemleak_ignore(p);
i tried this in -tip, it causes this build error:
arch/x86/kernel/aperture_64.c: In function ‘allocate_aperture’:
arch/x86/kernel/aperture_64.c:101: error: implicit declaration of function ‘kmemleak_ignore’
Ingo
next prev parent reply other threads:[~2009-08-16 10:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 15:26 [PATCH] kmemleak: Protect the seq start/next/stop sequence by rcu_read_lock() Catalin Marinas
2009-07-30 0:00 ` Andrew Morton
2009-07-30 8:24 ` Catalin Marinas
2009-08-02 11:14 ` Ingo Molnar
2009-08-10 15:55 ` Catalin Marinas
2009-08-10 18:45 ` Ingo Molnar
2009-08-10 22:56 ` Catalin Marinas
2009-08-11 7:32 ` Ingo Molnar
2009-08-11 8:55 ` Catalin Marinas
2009-08-12 12:17 ` Catalin Marinas
2009-08-12 15:32 ` Linus Torvalds
2009-08-12 15:39 ` Catalin Marinas
2009-08-12 20:52 ` Ingo Molnar
2009-08-12 22:16 ` kmemleak: Protect the seq start/next/stop sequence byrcu_read_lock() Catalin Marinas
2009-08-13 6:52 ` Ingo Molnar
2009-08-13 9:39 ` Catalin Marinas
2009-08-13 9:44 ` Ingo Molnar
2009-08-13 14:44 ` Catalin Marinas
2009-08-14 22:45 ` Catalin Marinas
2009-08-14 22:47 ` [PATCH] kmemleak: Allow rescheduling during an object scanning Catalin Marinas
2009-08-14 22:48 ` [PATCH] kmemleak: Ignore the aperture memory hole on x86_64 Catalin Marinas
2009-08-15 14:17 ` Ingo Molnar
2009-08-15 22:34 ` Catalin Marinas
2009-08-16 7:04 ` Ingo Molnar
2009-08-16 10:08 ` Ingo Molnar [this message]
2009-08-16 21:48 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090816100820.GA26474@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox