From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog
Date: Sun, 16 Aug 2009 17:27:55 +0100 [thread overview]
Message-ID: <20090816162755.GA14971@sirena.org.uk> (raw)
In-Reply-To: <20090816132812.GO4302@infomag.iguana.be>
On Sun, Aug 16, 2009 at 03:28:12PM +0200, Wim Van Sebroeck wrote:
> > +#define WM831X_WDOG_PRIMACT_WIDTH 2 /* WDOG_PRIMACT - [5:4] */
> These lines exceed 80 characters. Is there any reason why we can't reduce the spacing between the name and the value?
> Just let me know how we will proceed on my second question. I can then add this to the linux-2.6-watchdog-next tree.
The register definitions are automatically generated using the chip
design information using a tool which I'm not the only user for. It
simplifies maintinance to keep the output code as-is since it allows
easier comparison with future devices with the same or similar IP in
them. If anything were done I'd remove the comments.
next prev parent reply other threads:[~2009-08-16 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 16:43 [PATCH 1/5] backlight: Add WM831x backlight driver Mark Brown
2009-08-10 16:43 ` [PATCH 2/5] leds: Add WM831x status LED driver Mark Brown
2009-08-10 16:43 ` [PATCH 3/5] power_supply: Add driver for the PMU on WM831x PMICs Mark Brown
2009-08-14 2:00 ` Anton Vorontsov
2009-08-14 16:49 ` Mark Brown
2009-08-14 16:53 ` Anton Vorontsov
2009-08-10 16:43 ` [PATCH 4/5] RTC: Add support for RTCs on Wolfson WM831x devices Mark Brown
2009-08-10 18:55 ` [rtc-linux] " Alessandro Zummo
2009-08-10 20:57 ` Mark Brown
2009-08-10 21:08 ` [rtc-linux] " Alessandro Zummo
2009-08-16 22:35 ` Samuel Ortiz
2009-08-10 16:43 ` [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog Mark Brown
2009-08-11 12:40 ` Wim Van Sebroeck
2009-08-16 13:28 ` Wim Van Sebroeck
2009-08-16 16:27 ` Mark Brown [this message]
2009-08-17 12:13 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090816162755.GA14971@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox