Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog

Mark Brown
2009-08-16T16:28:03Z

On Sun, Aug 16, 2009 at 03:28:12PM +0200, Wim Van Sebroeck wrote:

> > +#define WM831X_WDOG_PRIMACT_WIDTH 2 /* WDOG_PRIMACT - [5:4] */

> These lines exceed 80 characters. Is there any reason why we can't reduce the spacing between the name and the value?

> Just let me know how we will proceed on my second question. I can then add this to the linux-2.6-watchdog-next tree.

The register definitions are automatically generated using the chip
design information using a tool which I'm not the only user for. It
simplifies maintinance to keep the output code as-is since it allows
easier comparison with future devices with the same or similar IP in
them. If anything were done I'd remove the comments.