Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog

Wim Van Sebroeck
2009-08-16T13:28:14Z

Hi Mark,

> The WM831x series of devices provide a watchdog with configurable
> behaviour on timer expiry.
>
> Currently this driver support refreshes via a register or GPIO line and
> autonomous refreshes from a hardware source (eg, a clock).
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>

the driver is OK. Just 2 small remarks:
> +static struct watchdog_info ident = {
> + .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE,
> + .identity = "WM831x Watchdog",
> +};

this can be static const struct in the future (need to do a clean-up on that).

> +#define WM831X_WDOG_SECACT_MASK 0x0300 /* WDOG_SECACT - [9:8] */
> +#define WM831X_WDOG_SECACT_SHIFT 8 /* WDOG_SECACT - [9:8] */
> +#define WM831X_WDOG_SECACT_WIDTH 2 /* WDOG_SECACT - [9:8] */
> +#define WM831X_WDOG_PRIMACT_MASK 0x0030 /* WDOG_PRIMACT - [5:4] */
> +#define WM831X_WDOG_PRIMACT_SHIFT 4 /* WDOG_PRIMACT - [5:4] */
> +#define WM831X_WDOG_PRIMACT_WIDTH 2 /* WDOG_PRIMACT - [5:4] */

These lines exceed 80 characters. Is there any reason why we can't reduce the spacing between the name and the value?

Just let me know how we will proceed on my second question. I can then add this to the linux-2.6-watchdog-next tree.

Kind regards,
Wim.