From: Stephen Hemminger <shemminger@vyatta.com>
To: john stultz <johnstul@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: clocksource changes in 2.6.31 - possible regression
Date: Mon, 17 Aug 2009 09:03:19 -0700 [thread overview]
Message-ID: <20090817090319.20979986@nehalam> (raw)
The following commit causes a change for kernels built with HRT but
not actually using HRT. I typically use the generic kernel we ship
on test machines, and that kernel has NOHZ and HRT (for power savings/virt
and HRT for QoS), but I want to be able to enable TSC as a clock source
when doing performance tests with pktgen.
The machine in question is a several year old Opteron box, that
normally reports clocksources: acpi_pm jiffies tsc
but now with 2.6.31-rc6, it only has acpi_pm.
Since HRT/NOHZ is not really runtime configurable, I think the
proper behavior is:
* kernel reports all possible clocksources and chooses the best
by default
* if user demands a different clocksource, the kernel should use that
but degrade if necessary: ie. high-res timers have less (maybe even
only HZ accuracy), and nohz should be automatically disabled if
needed
commit 3f68535adad8dd89499505a65fb25d0e02d118cc
Author: john stultz <johnstul@us.ibm.com>
Date: Wed Jan 21 22:53:22 2009 -0700
clocksource: sanity check sysfs clocksource changes
Thomas, Andrew and Ingo pointed out that we don't have any safety checks
in the clocksource sysfs entries to make sure sysadmins don't try to
change the clocksource to a non high-res timer capable clocksource (such
as jiffies) when high-res timers (HRT) is enabled. Doing so will likely
hang a system.
Correct this by filtering non HRT clocksources from available_clocksources
and not accepting non HRT clocksources with HRT enabled.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
next reply other threads:[~2009-08-17 16:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 16:03 Stephen Hemminger [this message]
2009-08-17 17:46 ` clocksource changes in 2.6.31 - possible regression Thomas Gleixner
2009-08-17 17:48 ` john stultz
2009-08-17 18:01 ` Stephen Hemminger
2009-08-17 18:15 ` john stultz
2009-08-17 18:27 ` Stephen Hemminger
2009-08-17 18:34 ` Thomas Gleixner
2009-08-17 19:54 ` Stephen Hemminger
2009-08-17 20:04 ` Thomas Gleixner
2009-08-17 20:27 ` Stephen Hemminger
2009-08-17 20:44 ` Thomas Gleixner
2009-08-17 21:10 ` john stultz
2009-08-17 21:37 ` john stultz
2009-08-17 21:45 ` Stephen Hemminger
2009-08-17 22:23 ` john stultz
2009-08-17 23:02 ` Stephen Hemminger
2009-08-17 23:17 ` john stultz
2009-08-17 23:27 ` Stephen Hemminger
2009-08-17 23:40 ` [PATCH] make tsc=reliable override boot time stability checks john stultz
2009-08-18 1:39 ` Alok Kataria
2009-08-19 1:04 ` john stultz
2009-08-28 19:16 ` [tip:x86/tsc] x86: Make " tip-bot for john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817090319.20979986@nehalam \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox