From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] inline __fatal_signal_pending
Date: Mon, 17 Aug 2009 12:35:49 -0700 (PDT) [thread overview]
Message-ID: <20090817193549.CE7514730F@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Monday, 17 August 2009 18:31:26 +0200 <20090817163126.GA14581@redhat.com>
> In fact, I think we do not need 2 helpers. I mean, fatal_signal_pending()
> does not need the signal_pending() check, we can just rename
> __fatal_signal_pending() to fatal_signal_pending(). Should be another
> change of course.
Right, I thought of that too. I wasn't entirely sure that signal_pending()
vs test_tsk_thread_flag() doesn't have some important barrier-like ordering
effect that just the unlocked sigismember() check wouldn't have. But if not,
fatal_signal_pending() indeed really only needs to be that one instruction.
Thanks,
Roland
prev parent reply other threads:[~2009-08-17 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 0:32 [PATCH] inline __fatal_signal_pending Roland McGrath
2009-08-17 16:31 ` Oleg Nesterov
2009-08-17 19:35 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817193549.CE7514730F@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox