From: Chris Wright <chrisw@sous-sol.org>
To: Faidon Liambotis <paravoid@debian.org>
Cc: Chris Wright <chrisw@sous-sol.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <David.Woodhouse@intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [regression, bisected] fails to boot on Dell Optiplex 760 with VT-d enabled
Date: Mon, 17 Aug 2009 16:29:37 -0700 [thread overview]
Message-ID: <20090817232937.GK24885@sequoia.sous-sol.org> (raw)
In-Reply-To: <4A89E63E.407@debian.org>
* Faidon Liambotis (paravoid@debian.org) wrote:
> As an observation, David's patch is checking if *both* iommu->cap and
> iommu->ecap are -1, while yours checks for either. You're also checking
> for ver. Obviously, I have no idea which of the two is more correct.
David's looks fine to me, and as a bonus it's already queued up ;-)
None of those registers should return -1.
thanks,
-chris
prev parent reply other threads:[~2009-08-17 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 21:27 [regression, bisected] fails to boot on Dell Optiplex 760 with VT-d enabled Faidon Liambotis
2009-08-17 22:17 ` David Woodhouse
2009-08-17 22:59 ` Faidon Liambotis
2009-08-17 23:11 ` Chris Wright
2009-08-17 23:22 ` Faidon Liambotis
2009-08-17 23:29 ` Chris Wright [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817232937.GK24885@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=David.Woodhouse@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paravoid@debian.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox