Make LSM_MMAP_MIN_ADDR default match its help text.

Make LSM_MMAP_MIN_ADDR default match its help text.

[Dave Jones]

Commit 788084aba2ab7348257597496befcbccabdc98a3 added the LSM_MMAP_MIN_ADDR
option, whose help text states "For most ia64, ppc64 and x86 users with lots
of address space a value of 65536 is reasonable and should cause no problems."
Which implies that it's default setting was typoed.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.30.noarch/security/Kconfig~	2009-08-18 13:45:33.000000000 -0400
+++ linux-2.6.30.noarch/security/Kconfig	2009-08-18 13:45:36.000000000 -0400
@@ -116,7 +116,7 @@ config SECURITY_ROOTPLUG
 config LSM_MMAP_MIN_ADDR
 	int "Low address space for LSM to from user allocation"
 	depends on SECURITY && SECURITY_SELINUX
-	default 65535
+	default 65536
 	help
 	  This is the portion of low virtual memory which should be protected
 	  from userspace allocation.  Keeping a user from writing to low pages

Re: Make LSM_MMAP_MIN_ADDR default match its help text.

[Eric Paris]

On Tue, 2009-08-18 at 13:47 -0400, Dave Jones wrote:
> Commit 788084aba2ab7348257597496befcbccabdc98a3 added the LSM_MMAP_MIN_ADDR
> option, whose help text states "For most ia64, ppc64 and x86 users with lots
> of address space a value of 65536 is reasonable and should cause no problems."
> Which implies that it's default setting was typoed.

Acked-by: Eric Paris <eparis@redhat.com>

This can wait or go now.  the tests against this are always a strict >
(not >=) and they are always rounded to PAGE_SIZE.  Thus both have the
same address protections.

-Eric

> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- linux-2.6.30.noarch/security/Kconfig~	2009-08-18 13:45:33.000000000 -0400
> +++ linux-2.6.30.noarch/security/Kconfig	2009-08-18 13:45:36.000000000 -0400
> @@ -116,7 +116,7 @@ config SECURITY_ROOTPLUG
>  config LSM_MMAP_MIN_ADDR
>  	int "Low address space for LSM to from user allocation"
>  	depends on SECURITY && SECURITY_SELINUX
> -	default 65535
> +	default 65536
>  	help
>  	  This is the portion of low virtual memory which should be protected
>  	  from userspace allocation.  Keeping a user from writing to low pages

Re: Make LSM_MMAP_MIN_ADDR default match its help text.

[Andreas Schwab]

Dave Jones <davej@redhat.com> writes:

>  config LSM_MMAP_MIN_ADDR
>  	int "Low address space for LSM to from user allocation"

This sentence no verb.

Andreas.
---
>From 4ba5116764386ceb1a9da4cb6800defd84f0e3c1 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <schwab@linux-m68k.org>
Date: Tue, 18 Aug 2009 22:08:43 +0200
Subject: [PATCH] Fix prompt for LSM_MMAP_MIN_ADDR.

Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
 security/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/security/Kconfig b/security/Kconfig
index 9c60c34..4d1a2e3 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -114,7 +114,7 @@ config SECURITY_ROOTPLUG
 	  If you are unsure how to answer this question, answer N.
 
 config LSM_MMAP_MIN_ADDR
-	int "Low address space for LSM to from user allocation"
+	int "Low address space for LSM to protect from user allocation"
 	depends on SECURITY && SECURITY_SELINUX
 	default 65535
 	help
-- 
1.6.4

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Make LSM_MMAP_MIN_ADDR default match its help text.

[Eric Paris]

On Tue, 2009-08-18 at 22:14 +0200, Andreas Schwab wrote:
> Dave Jones <davej@redhat.com> writes:
> 
> >  config LSM_MMAP_MIN_ADDR
> >  	int "Low address space for LSM to from user allocation"
> 
> This sentence no verb.
> 
> Andreas.
> ---
> From 4ba5116764386ceb1a9da4cb6800defd84f0e3c1 Mon Sep 17 00:00:00 2001
> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Tue, 18 Aug 2009 22:08:43 +0200
> Subject: [PATCH] Fix prompt for LSM_MMAP_MIN_ADDR.
> 
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>

Acked-by: Eric Paris <eparis@redhat.com>



> ---
>  security/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/security/Kconfig b/security/Kconfig
> index 9c60c34..4d1a2e3 100644
> --- a/security/Kconfig
> +++ b/security/Kconfig
> @@ -114,7 +114,7 @@ config SECURITY_ROOTPLUG
>  	  If you are unsure how to answer this question, answer N.
>  
>  config LSM_MMAP_MIN_ADDR
> -	int "Low address space for LSM to from user allocation"
> +	int "Low address space for LSM to protect from user allocation"
>  	depends on SECURITY && SECURITY_SELINUX
>  	default 65535
>  	help
> -- 
> 1.6.4
> 

Re: Make LSM_MMAP_MIN_ADDR default match its help text.

[Dave Jones]

On Tue, Aug 18, 2009 at 10:14:29PM +0200, Andreas Schwab wrote:
 > Dave Jones <davej@redhat.com> writes:
 > 
 > >  config LSM_MMAP_MIN_ADDR
 > >  	int "Low address space for LSM to from user allocation"
 > 
 > This sentence no verb.

Oops. I accidentally that.

Thanks.

	Dave