From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,apic: set cpu_has_apic manually for discrete apic
Date: Wed, 19 Aug 2009 20:15:00 +0400 [thread overview]
Message-ID: <20090819161500.GA5457@lenovo> (raw)
In-Reply-To: <20090816195736.GB4788@lenovo>
[Cyrill Gorcunov - Sun, Aug 16, 2009 at 11:57:36PM +0400]
|
| In case of discrete apic (due to hardware or firmware reason)
| cpuid may not retrieve cpu_has_apic bit. But we rely on this
| bit in SMP compiled kernels. So instead of long condition checking
| we set cpu_has_apic bit manually and check it only in further
| code flow.
|
| Note that the case is applied to x86-32 pretty old machines only.
| Also verify_local_APIC is the only place where such a trick
| could be done. We can't do it earlier since there could be
| a BIOS bug and other checks which we are to pass to ensure
| that APIC is functional.
|
| The patch also make lapic_shutdown, disable_IO_APIC callable
| which should take place even on discrete apics.
|
| As a side effect it makes lapic sysfs device available
| for such machines so lets check for apic being integrated
| since we don't support suspend/resume for disrete apics.
|
| Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
| ---
Please drop this RFC now as to eliminate side effects
a number of quirks (MCE,MSI) would be needed. I didn't trigger
problems because not all interrupt types were covered
with qemu. The simpliest (and more safe) approach will
be just to fix lapic_shutdown and disable_IO_APIC for
discrete apic case. Will cook a patch.
-- Cyrill
prev parent reply other threads:[~2009-08-19 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 19:57 [RFC -tip] x86,apic: set cpu_has_apic manually for discrete apic Cyrill Gorcunov
2009-08-19 16:15 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819161500.GA5457@lenovo \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox