From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbZHTMPc (ORCPT ); Thu, 20 Aug 2009 08:15:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753879AbZHTMPc (ORCPT ); Thu, 20 Aug 2009 08:15:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53987 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602AbZHTMPb (ORCPT ); Thu, 20 Aug 2009 08:15:31 -0400 Date: Thu, 20 Aug 2009 14:15:31 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , LKML , Evgeniy Polyakov , ocfs2-devel@oss.oracle.com, Joel Becker , Felix Blyakher , xfs@oss.sgi.com, Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, OGAWA Hirofumi , linux-ext4@vger.kernel.org, tytso@mit.edu Subject: Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode Message-ID: <20090820121531.GC16486@duck.novell.com> References: <1250697884-22288-1-git-send-email-jack@suse.cz> <1250697884-22288-8-git-send-email-jack@suse.cz> <20090819162638.GE6150@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090819162638.GE6150@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 19-08-09 12:26:38, Christoph Hellwig wrote: > Looks good to me. Eventually we should use those SYNC_ flags also all > through the fsync codepath, but I'll see if I can incorporate that in my > planned fsync rewrite. Yes, I thought I'll leave that for later. BTW it should be fairly easy to teach generic_sync_file() to do fdatawait() before calling ->fsync() if the filesystem sets some flag in inode->i_mapping (or somewhere else) as is needed for XFS, btrfs, etc. Honza -- Jan Kara SUSE Labs, CR