* [PATCH] TTY: fix typos
@ 2009-08-20 19:23 Alan Stern
2009-08-20 19:29 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Alan Stern @ 2009-08-20 19:23 UTC (permalink / raw)
To: Greg KH; +Cc: Alan Cox, Kernel development list
This patch (as1282) fixes some obvious typos in the TTY core.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
Index: usb-2.6/drivers/char/tty_port.c
===================================================================
--- usb-2.6.orig/drivers/char/tty_port.c
+++ usb-2.6/drivers/char/tty_port.c
@@ -100,7 +100,7 @@ EXPORT_SYMBOL(tty_port_tty_set);
static void tty_port_shutdown(struct tty_port *port)
{
if (port->ops->shutdown &&
- test_and_clear_bit(ASYNC_INITIALIZED, &port->flags))
+ test_and_clear_bit(ASYNCB_INITIALIZED, &port->flags))
port->ops->shutdown(port);
}
@@ -311,7 +311,7 @@ int tty_port_close_start(struct tty_port
port->ops->drop(port);
return 0;
}
- set_bit(ASYNC_CLOSING, &port->flags);
+ set_bit(ASYNCB_CLOSING, &port->flags);
tty->closing = 1;
spin_unlock_irqrestore(&port->lock, flags);
/* Don't block on a stalled port, just pull the chain */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] TTY: fix typos
2009-08-20 19:23 [PATCH] TTY: fix typos Alan Stern
@ 2009-08-20 19:29 ` Greg KH
2009-08-20 19:34 ` Alan Stern
2009-08-20 22:00 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: Greg KH @ 2009-08-20 19:29 UTC (permalink / raw)
To: Alan Stern; +Cc: Alan Cox, Kernel development list
On Thu, Aug 20, 2009 at 03:23:47PM -0400, Alan Stern wrote:
> This patch (as1282) fixes some obvious typos in the TTY core.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
Ick, this looks like it needs to go in for .31, right?
thanks,
greg k-h
> Index: usb-2.6/drivers/char/tty_port.c
> ===================================================================
> --- usb-2.6.orig/drivers/char/tty_port.c
> +++ usb-2.6/drivers/char/tty_port.c
> @@ -100,7 +100,7 @@ EXPORT_SYMBOL(tty_port_tty_set);
> static void tty_port_shutdown(struct tty_port *port)
> {
> if (port->ops->shutdown &&
> - test_and_clear_bit(ASYNC_INITIALIZED, &port->flags))
> + test_and_clear_bit(ASYNCB_INITIALIZED, &port->flags))
> port->ops->shutdown(port);
>
> }
> @@ -311,7 +311,7 @@ int tty_port_close_start(struct tty_port
> port->ops->drop(port);
> return 0;
> }
> - set_bit(ASYNC_CLOSING, &port->flags);
> + set_bit(ASYNCB_CLOSING, &port->flags);
> tty->closing = 1;
> spin_unlock_irqrestore(&port->lock, flags);
> /* Don't block on a stalled port, just pull the chain */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] TTY: fix typos
2009-08-20 19:29 ` Greg KH
@ 2009-08-20 19:34 ` Alan Stern
2009-08-20 20:42 ` Greg KH
2009-08-20 22:00 ` Alan Cox
1 sibling, 1 reply; 5+ messages in thread
From: Alan Stern @ 2009-08-20 19:34 UTC (permalink / raw)
To: Greg KH; +Cc: Alan Cox, Kernel development list
On Thu, 20 Aug 2009, Greg KH wrote:
> On Thu, Aug 20, 2009 at 03:23:47PM -0400, Alan Stern wrote:
> > This patch (as1282) fixes some obvious typos in the TTY core.
> >
> > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
>
> Ick, this looks like it needs to go in for .31, right?
No, these are typos in the new code queued for .32. 2.6.31 looks all
right.
Alan Stern
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] TTY: fix typos
2009-08-20 19:34 ` Alan Stern
@ 2009-08-20 20:42 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2009-08-20 20:42 UTC (permalink / raw)
To: Alan Stern; +Cc: Alan Cox, Kernel development list
On Thu, Aug 20, 2009 at 03:34:40PM -0400, Alan Stern wrote:
> On Thu, 20 Aug 2009, Greg KH wrote:
>
> > On Thu, Aug 20, 2009 at 03:23:47PM -0400, Alan Stern wrote:
> > > This patch (as1282) fixes some obvious typos in the TTY core.
> > >
> > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > > CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
> >
> > Ick, this looks like it needs to go in for .31, right?
>
> No, these are typos in the new code queued for .32. 2.6.31 looks all
> right.
Ok, thanks for letting me know.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] TTY: fix typos
2009-08-20 19:29 ` Greg KH
2009-08-20 19:34 ` Alan Stern
@ 2009-08-20 22:00 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: Alan Cox @ 2009-08-20 22:00 UTC (permalink / raw)
To: Greg KH; +Cc: Alan Stern, Kernel development list
On Thu, 20 Aug 2009 12:29:15 -0700
Greg KH <greg@kroah.com> wrote:
> On Thu, Aug 20, 2009 at 03:23:47PM -0400, Alan Stern wrote:
> > This patch (as1282) fixes some obvious typos in the TTY core.
> >
> > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
>
> Ick, this looks like it needs to go in for .31, right?
Ackity ack - yes
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-08-20 21:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-20 19:23 [PATCH] TTY: fix typos Alan Stern
2009-08-20 19:29 ` Greg KH
2009-08-20 19:34 ` Alan Stern
2009-08-20 20:42 ` Greg KH
2009-08-20 22:00 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox