From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Alex Chiang <achiang@hp.com>, Andi Kleen <andi@firstfloor.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: add /proc/cpuinfo/physical id quirks
Date: Fri, 21 Aug 2009 02:32:32 +0200 [thread overview]
Message-ID: <20090821003232.GD29994@basil.fritz.box> (raw)
In-Reply-To: <4A8DC349.5060508@zytor.com>
> I agree... if this ID is used for topology detection, we shouldn't
> replace it arbitrarily with information from BIOS just to hope that it
> matches the motherboard stencil. *Furthermore*, there is no reason why
> motherboard stencilAs are purely numeric... consider the rather obvious
> case of two rows of four CPUs; they may have CPU slots labelled A1, A2,
> A3, A4, B1, B2, B3, B4. It might very well be the right thing to
> support arbitrary strings for platforms we recognize.
Maintaining a manual mapping to strings in the kernel to such strings
would be just crazy. You would need a new entry for basically
every system.
The reason to correct SOCKETID is that it it is output on errors.
If it is numerical and you know it's wrong you can correct it,
and then you can identify the right CPU. Otherwise you lose.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-08-21 0:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 16:36 [PATCH] x86: add /proc/cpuinfo/physical id quirks Alex Chiang
2009-08-14 19:07 ` Suresh Siddha
2009-08-14 19:27 ` Alex Chiang
2009-08-14 19:56 ` Suresh Siddha
2009-08-19 21:02 ` Alex Chiang
2009-08-20 18:56 ` Suresh Siddha
2009-08-20 20:54 ` Alex Chiang
2009-08-20 21:03 ` Andi Kleen
2009-08-20 21:20 ` Alex Chiang
2009-08-20 21:26 ` Suresh Siddha
2009-08-20 21:42 ` H. Peter Anvin
2009-08-20 21:59 ` Alex Chiang
2009-08-20 22:04 ` H. Peter Anvin
2009-08-21 0:32 ` Andi Kleen [this message]
2009-08-21 1:51 ` H. Peter Anvin
2009-08-21 5:02 ` Alex Chiang
2009-08-20 21:22 ` Suresh Siddha
2009-08-21 0:38 ` Andi Kleen
2009-08-20 21:11 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821003232.GD29994@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=achiang@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox