From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: soni.trilok@gmail.com, greg@kroah.com, arve@android.com,
linux-kernel@vger.kernel.org, swetland@google.com,
dmitry.torokhov@gmail.com, dtor@mail.ru,
linux-input@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: Synaptics touchscreen for HTC Dream: check that smbus is available
Date: Fri, 21 Aug 2009 16:23:05 +0200 [thread overview]
Message-ID: <20090821142305.GA1599@ucw.cz> (raw)
In-Reply-To: <20090817164759.43c39f2d.akpm@linux-foundation.org>
On Mon 2009-08-17 16:47:59, Andrew Morton wrote:
> On Sat, 8 Aug 2009 15:40:50 +0200
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > > >> Because this driver is using smbus i2c apis, it will be good to add
> > > >> that check too.
> > > >
> > > > So I should do something like
> > > >
> > > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WORD_DATA))
> > > > __ __ __ __...
> > > >
> > > > in addition?
> > >
> > > Yes.
> >
> > Ok, here it is.
> >
> > ---
> >
> > Check that SMBUS APIs are available in touchscreen driver.
>
> Why?
Well, the touchscreen driver uses those APIs, and I was told I should
check. It does not matter for htc dream-like machines, but someone
might want to run it on pc...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-08-22 12:07 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 10:06 Support for synaptic touchscreen in HTC dream Pavel Machek
2009-07-14 10:20 ` Trilok Soni
2009-07-15 13:36 ` Pavel Machek
2009-07-15 17:33 ` Trilok Soni
2009-07-21 10:21 ` Pavel Machek
2009-07-21 10:34 ` Trilok Soni
2009-08-08 13:40 ` Synaptics touchscreen for HTC Dream: check that smbus is available Pavel Machek
2009-08-17 23:47 ` Andrew Morton
2009-08-21 14:23 ` Pavel Machek [this message]
2009-07-21 10:59 ` Threaded interrupts for synaptic touchscreen in HTC dream Pavel Machek
2009-07-21 11:36 ` Mark Brown
2009-07-21 12:18 ` Trilok Soni
2009-07-21 12:30 ` Trilok Soni
2009-07-21 12:49 ` Mark Brown
2009-07-21 16:04 ` Dmitry Torokhov
2009-07-21 20:30 ` Thomas Gleixner
2009-07-21 20:58 ` Dmitry Torokhov
2009-07-21 21:48 ` Thomas Gleixner
2009-07-21 22:25 ` Mark Brown
2009-07-22 10:44 ` Thomas Gleixner
2009-07-22 12:18 ` Mark Brown
2009-07-22 12:58 ` Thomas Gleixner
2009-07-22 13:30 ` Peter Zijlstra
2009-07-22 14:18 ` Thomas Gleixner
2009-07-22 14:32 ` Mark Brown
2009-07-22 14:52 ` Thomas Gleixner
2009-07-22 14:56 ` Mark Brown
2009-07-22 15:15 ` Thomas Gleixner
2009-07-22 15:56 ` Mark Brown
2009-07-22 16:57 ` David Brownell
2009-07-22 21:04 ` Thomas Gleixner
2009-07-22 21:57 ` Arve Hjønnevåg
2009-07-22 22:15 ` David Brownell
2009-07-22 23:30 ` Arve Hjønnevåg
2009-07-22 22:09 ` David Brownell
2009-07-23 4:43 ` Dmitry Torokhov
2009-07-22 13:31 ` Mark Brown
2009-07-22 17:04 ` David Brownell
2009-07-22 17:08 ` Mark Brown
2009-07-22 16:04 ` Dmitry Torokhov
2009-07-22 16:40 ` Thomas Gleixner
2009-07-22 16:57 ` Mark Brown
2009-07-22 17:08 ` Dmitry Torokhov
2009-07-22 17:13 ` David Brownell
2009-07-22 16:51 ` David Brownell
2009-07-22 16:39 ` David Brownell
2009-07-22 16:43 ` Thomas Gleixner
2009-07-22 17:34 ` David Brownell
2009-07-22 16:50 ` Mark Brown
2009-07-22 17:41 ` David Brownell
2009-07-21 20:43 ` Daniel Ribeiro
2009-07-21 12:30 ` Mark Brown
2009-07-23 14:55 ` Pavel Machek
2009-07-15 21:33 ` Support " Arve Hjønnevåg
2009-07-21 10:40 ` Pavel Machek
2009-07-14 17:52 ` Dmitry Torokhov
2009-07-15 13:48 ` Pavel Machek
2009-07-15 15:27 ` Dmitry Torokhov
2009-07-15 15:33 ` Brian Swetland
2009-07-15 17:26 ` Trilok Soni
2009-07-15 18:43 ` Arve Hjønnevåg
2009-07-15 20:24 ` Arve Hjønnevåg
2009-07-15 13:50 ` Pavel Machek
2009-08-08 14:02 ` HTC Dream for staging: small cleanups [was Re: Support for synaptic touchscreen in HTC dream] Pavel Machek
2009-07-14 20:25 ` Support for synaptic touchscreen in HTC dream Andreas Mohr
2009-07-14 20:33 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821142305.GA1599@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=greg@kroah.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox