From: Michal Schmidt <mschmidt@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Mark McLoughlin <markmc@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: DomU crashes during xenfb initialization
Date: Fri, 21 Aug 2009 15:13:52 +0200 [thread overview]
Message-ID: <20090821151352.1676de18@leela> (raw)
In-Reply-To: <20090821150922.72e12d9a@leela>
Dne Fri, 21 Aug 2009 15:09:22 +0200 Michal Schmidt napsal:
> Dne Fri, 21 Aug 2009 12:40:59 +0200 Michal Schmidt napsal:
> > So it crashes during Xen framebuffer initialization. And indeed,
> > disabling CONFIG_XEN_FBDEV_FRONTEND helps, the kernel then boots
> > fine.
> >
> > I git-bisected it and found that the bug was introduced by this
> > commit: commit ced40d0f3e8833bb8d7d8e2cbfac7da0bf7008c4
> > Author: Jeremy Fitzhardinge <jeremy@goop.org>
> > Date: Fri Feb 6 14:09:44 2009 -0800
> >
> > xen: pack all irq-related info together
>
> It's not this commit's fault. It just uncovered a latent bug.
> info->irq is -1 in xenfb_send_event(), so it calls
> notify_remote_via_irq(-1) which then dereferences out-of-array memory.
In xenfb_probe(), xenfb_connect_backend() is called after
register_framebuffer(). That looks suspicious. I'll see if switching
the order helps.
Michal
next prev parent reply other threads:[~2009-08-21 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 10:40 DomU crashes during xenfb initialization Michal Schmidt
2009-08-21 13:09 ` Michal Schmidt
2009-08-21 13:13 ` Michal Schmidt [this message]
2009-08-21 13:44 ` [PATCH] xenfb: connect to backend before registering fb Michal Schmidt
2009-08-21 22:45 ` Jeremy Fitzhardinge
2009-08-23 19:32 ` Michal Schmidt
2009-08-21 23:57 ` DomU crashes during xenfb initialization Morten P.D. Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821151352.1676de18@leela \
--to=mschmidt@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox