* [BUGFIX PATCH -tip] perf tools: Add OPT_END to option array of perf-trace
@ 2009-08-21 18:56 Masami Hiramatsu
2009-08-21 19:42 ` Ingo Molnar
2009-08-21 19:45 ` [tip:perfcounters/tracing] perf trace: " tip-bot for Masami Hiramatsu
0 siblings, 2 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2009-08-21 18:56 UTC (permalink / raw)
To: Ingo Molnar, lkml
Cc: systemtap, DLE, Masami Hiramatsu, Steven Rostedt,
Frederic Weisbecker, Peter Zijlstra, Arnaldo Carvalho de Melo,
Mike Galbraith, Xiao Guangrong, Zhaolei, Li Zefan, Lai Jiangshan,
Tom Zanussi
Add OPT_END to option array of perf-trace for fixing a SEGV bug when
showing perf-trace help message.
Without this patch;
./perf trace -h
usage: perf trace [<options>] <command>
-D, --dump-raw-trace dump raw trace in ASCII
-v, --verbose be more verbose (show symbol address, etc)
-f, Segmentation fault
With this patch:
./perf trace -h
usage: perf trace [<options>] <command>
-D, --dump-raw-trace dump raw trace in ASCII
-v, --verbose be more verbose (show symbol address, etc)
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Zhaolei <zhaolei@cn.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
---
tools/perf/builtin-trace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 88eef71..dd3c2e7 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -257,6 +257,7 @@ static const struct option options[] = {
"dump raw trace in ASCII"),
OPT_BOOLEAN('v', "verbose", &verbose,
"be more verbose (show symbol address, etc)"),
+ OPT_END()
};
int cmd_trace(int argc, const char **argv, const char *prefix __used)
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [BUGFIX PATCH -tip] perf tools: Add OPT_END to option array of perf-trace
2009-08-21 18:56 [BUGFIX PATCH -tip] perf tools: Add OPT_END to option array of perf-trace Masami Hiramatsu
@ 2009-08-21 19:42 ` Ingo Molnar
2009-08-21 19:45 ` [tip:perfcounters/tracing] perf trace: " tip-bot for Masami Hiramatsu
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-08-21 19:42 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: lkml, systemtap, DLE, Steven Rostedt, Frederic Weisbecker,
Peter Zijlstra, Arnaldo Carvalho de Melo, Mike Galbraith,
Xiao Guangrong, Zhaolei, Li Zefan, Lai Jiangshan, Tom Zanussi
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Add OPT_END to option array of perf-trace for fixing a SEGV bug
> when showing perf-trace help message.
applied, thanks!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perfcounters/tracing] perf trace: Add OPT_END to option array of perf-trace
2009-08-21 18:56 [BUGFIX PATCH -tip] perf tools: Add OPT_END to option array of perf-trace Masami Hiramatsu
2009-08-21 19:42 ` Ingo Molnar
@ 2009-08-21 19:45 ` tip-bot for Masami Hiramatsu
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Masami Hiramatsu @ 2009-08-21 19:45 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, mingo, efault, peterz, zhaolei, dle-develop, fweisbec,
rostedt, tglx, laijs, mhiramat, systemtap, hpa, linux-kernel,
tzanussi, lizf, xiaoguangrong, mingo
Commit-ID: 1909629fb1ec9800cf2cb0091870d6a1c1ca665f
Gitweb: http://git.kernel.org/tip/1909629fb1ec9800cf2cb0091870d6a1c1ca665f
Author: Masami Hiramatsu <mhiramat@redhat.com>
AuthorDate: Fri, 21 Aug 2009 14:56:03 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 21 Aug 2009 21:42:43 +0200
perf trace: Add OPT_END to option array of perf-trace
Add OPT_END to option array of perf-trace for fixing a SEGV bug when
showing perf-trace help message.
Without this patch;
./perf trace -h
usage: perf trace [<options>] <command>
-D, --dump-raw-trace dump raw trace in ASCII
-v, --verbose be more verbose (show symbol address, etc)
-f, Segmentation fault
With this patch:
./perf trace -h
usage: perf trace [<options>] <command>
-D, --dump-raw-trace dump raw trace in ASCII
-v, --verbose be more verbose (show symbol address, etc)
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: systemtap <systemtap@sources.redhat.com>
Cc: DLE <dle-develop@lists.sourceforge.net>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Zhaolei <zhaolei@cn.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <20090821185603.11039.62109.stgit@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
tools/perf/builtin-trace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 88eef71..dd3c2e7 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -257,6 +257,7 @@ static const struct option options[] = {
"dump raw trace in ASCII"),
OPT_BOOLEAN('v', "verbose", &verbose,
"be more verbose (show symbol address, etc)"),
+ OPT_END()
};
int cmd_trace(int argc, const char **argv, const char *prefix __used)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-21 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-21 18:56 [BUGFIX PATCH -tip] perf tools: Add OPT_END to option array of perf-trace Masami Hiramatsu
2009-08-21 19:42 ` Ingo Molnar
2009-08-21 19:45 ` [tip:perfcounters/tracing] perf trace: " tip-bot for Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox