From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755720AbZHUTv6 (ORCPT ); Fri, 21 Aug 2009 15:51:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755592AbZHUTv5 (ORCPT ); Fri, 21 Aug 2009 15:51:57 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:55502 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755488AbZHUTv5 (ORCPT ); Fri, 21 Aug 2009 15:51:57 -0400 Date: Fri, 21 Aug 2009 21:51:31 +0200 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , Peter Zijlstra , Linus Torvalds , Theodore Tso , Arjan van de Ven , Greg KH , "Luis R. Rodriguez" , zippel@linux-m68k.org, linux-kbuild@vger.kernel.org, Sam Ravnborg , Jonathan Corbet , Alan Jenkins , Andi Kleen Subject: Re: [PATCH 00/14] kconfig: streamline distro configs for testers Message-ID: <20090821195131.GE5356@elte.hu> References: <20090819025634.987354707@goodmis.org> <20090821143525.GH11098@elte.hu> <20090821145406.GA3659@elte.hu> <20090821162822.GA20898@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > > On Fri, 21 Aug 2009, Ingo Molnar wrote: > > > > > * Steven Rostedt wrote: > > > > > > > > On Fri, 21 Aug 2009, Steven Rostedt wrote: > > > > > > > > OK, I found the bug. There's a dependency missing. > > > > > > > > $ make localyesconfig > > > > HOSTCC scripts/basic/fixdep > > > > HOSTCC scripts/basic/docproc > > > > HOSTCC scripts/basic/hash > > > > using config: '/boot/config-2.6.27.25-78.2.56.fc9.x86_64' > > > > /bin/sh: line 8: scripts/kconfig/conf: No such file or directory > > > > make[1]: *** [localyesconfig] Error 127 > > > > make: *** [localyesconfig] Error 2 > > > > > > > > Thus the script failed to run. But the sed command that converts the '=m' > > > > to '=y' still ran. This gives us a distro config with all modules > > > > converted to built in! > > > > > > Funny that localmodconfig does not have this bug. > > > > ... add to that i dont use modules much so i probably hit that > > localyesconfig bug ;-) > > > > btw: mind adding localrandconfig too? It would be a perfect tool to > > randomize all configs except a 'must have' core set of options. > > > > ( Or is this already possible via some existing kconfig feature? I > > remember having seen something related, did that ever get > > upstream? A quick grep in scripts/ shows nothing but i might have > > missed it.) > > OK, I'll add that to my todo list. Note, it the local config is > only as good as the starting .config. That is, it never touches =y > settings, because it only uses loaded modules as a base. Thus if > something is set to =y it will always be set to =y. > > What would you have in mind. Just randomly enabling modules? If we > enable a "y" config then the next local*config will still keep > that set. Why - isnt local*config picking up environmental (currently running kernel) properties? I.e. it would always set those things that are needed - and randomize the rest. Have i misunderstood how it works? Ingo