From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <JBeulich@novell.com>
Cc: tglx@linutronix.de, hpa@zytor.com, sam@ravnborg.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: properly annotate alternatives.c
Date: Fri, 21 Aug 2009 22:09:08 +0200 [thread overview]
Message-ID: <20090821200908.GF5356@elte.hu> (raw)
In-Reply-To: <4A8BC8A00200007800010823@vpn.id2.novell.com>
* Jan Beulich <JBeulich@novell.com> wrote:
> Some of the NOPs tables aren't used on 64-bits, quite some code and
> data is needed post-init for module loading only, and a couple of
> functions aren't used outside that file (i.e. can be static, and don't
> need to be exported).
>
> The change to __INITDATA/__INITRODATA is needed to avoid an assembler
> warning.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
>
> ---
> arch/x86/include/asm/alternative.h | 7 ----
> arch/x86/kernel/alternative.c | 56 +++++++++++++++++++++----------------
> include/linux/init.h | 12 ++++++-
> 3 files changed, 42 insertions(+), 33 deletions(-)
looks like a nice improvement. Sam, what do you think?
Ingo
next prev parent reply other threads:[~2009-08-21 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 7:40 [PATCH] x86: properly annotate alternatives.c Jan Beulich
2009-08-21 20:09 ` Ingo Molnar [this message]
2009-08-21 21:38 ` Sam Ravnborg
2009-08-21 23:13 ` [tip:x86/asm] " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821200908.GF5356@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox