public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: linux-acpi@vger.kernel.org
Cc: Sujith Thomas <sujith.thomas@intel.com>,
	Zhang Rui <rui.zhang@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3,v2] acpi: thermal/sysfs-api.txt: document passive attribute for thermal zones
Date: Sat, 22 Aug 2009 13:57:20 +0200	[thread overview]
Message-ID: <200908221357.21567.elendil@planet.nl> (raw)
In-Reply-To: <200908211059.36774.elendil@planet.nl>

Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Sujith Thomas <sujith.thomas@intel.com>
---

While working on some further patches I discovered that polling_delay does
not actually determine the polling interval for a forced passive trip
point. Instead a hardcoded interval of 1 second is used (passive_delay).

I also saw that the thermal_sys driver is somewhat independent of ACPI,
so the third patch in the series may not be appropriate.

diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
index 48e9c5c..f6b3743 100644
--- a/Documentation/thermal/sysfs-api.txt
+++ b/Documentation/thermal/sysfs-api.txt
@@ -3,7 +3,7 @@ Generic Thermal Sysfs driver How To
 
 Written by Sujith Thomas <sujith.thomas@intel.com>, Zhang Rui <rui.zhang@intel.com>
 
-Updated: 2 January 2008
+Updated: 21 August 2009
 
 Copyright (c)  2008 Intel Corporation
 
@@ -199,6 +199,15 @@ cdev[0-*]_trip_point
 	point.
 	RO, Optional
 
+passive
+	Attribute is only present for zones which do not have a passive
+	cooling policy (_PSV) defined in ACPI. Default is zero and can be
+	set to a temperature (in millidegrees) to enable a passive trip
+	point for the zone. Activation is done by polling with an interval
+	of 1 second.
+	Unit: millidegrees Celsius
+	RW, Optional
+
 *****************************
 * Cooling device attributes *
 *****************************
@@ -230,8 +239,9 @@ thermal_zone_device (thermal_zone1) with 4 trip points in all.
 It has one processor and one fan, which are both registered as
 thermal_cooling_device.
 
-If the processor is listed in _PSL method, and the fan is listed in _AL0
-method, the sys I/F structure will be built like this:
+If the processor is listed in _PSL method, the fan is listed in _AL0
+method, and the zone has a _PSV method, the sys I/F structure will be
+built like this:
 
 /sys/class/thermal:
 

  reply	other threads:[~2009-08-22 11:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  8:55 [PATCH 0/3] acpi: improvements for Documentation/thermal/sysfs-api.txt Frans Pop
2009-08-21  8:58 ` [PATCH 1/3] acpi: thermal/sysfs-api.txt: reformat for improved readability Frans Pop
2009-08-21  8:59 ` [PATCH 2/3] acpi: thermal/sysfs-api.txt: document passive attribute for thermal zones Frans Pop
2009-08-22 11:57   ` Frans Pop [this message]
2009-08-21  9:02 ` [PATCH 3/3] acpi: thermal/sysfs-api.txt: move to acpi directory Frans Pop
2009-08-24  0:55   ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908221357.21567.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox