From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Matthias Urlichs <matthias@urlichs.de>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Amerigo Wang <xiyou.wangcong@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Nicolas Palix <npalix@diku.dk>,
linux-kernel@vger.kernel.org,
Yoann Padioleau <yoann.padioleau@gmail.com>,
Julia Lawall <julia@diku.dk>, Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, akpm@linux-foundation.org
Subject: Re: [PATCH v2] scripts: add typdef removal tool
Date: Mon, 24 Aug 2009 00:06:56 +0800 [thread overview]
Message-ID: <20090823160656.GB12070@hack> (raw)
In-Reply-To: <1251032950.10339.1101.camel@kiste>
On Sun, Aug 23, 2009 at 03:09:10PM +0200, Matthias Urlichs wrote:
>On Fri, 2009-08-21 at 10:48 +0200, Jiri Slaby wrote:
>> >> +if [[ $# -lt 3 ]]; then
>>
>> Could that be [ ] instead of [[ ]]?
>>
>Yes. In fact, it should be, as [[ ]] is a bashism.
Also that the classic test command is enough here,
no need to bother conditional expression.
--
Live like a child, think like the god.
next prev parent reply other threads:[~2009-08-23 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 5:39 [PATCH v2] scripts: add typdef removal tool Luis R. Rodriguez
2009-08-17 6:02 ` Amerigo Wang
2009-08-21 8:48 ` Jiri Slaby
2009-08-23 13:09 ` Matthias Urlichs
2009-08-23 16:06 ` Américo Wang [this message]
2009-08-23 13:22 ` Matthias Urlichs
2009-08-23 16:04 ` Américo Wang
2009-08-23 17:59 ` Jiri Slaby
2009-08-25 14:35 ` Matthias Urlichs
2010-09-19 8:19 ` Pekka Enberg
2010-09-19 8:49 ` Joe Perches
2010-09-19 9:30 ` Pekka Enberg
2010-09-19 15:03 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090823160656.GB12070@hack \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jirislaby@gmail.com \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=matthias@urlichs.de \
--cc=npalix@diku.dk \
--cc=yoann.padioleau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox