* [PATCH resend] vsprintf: use WARN_ON_ONCE
@ 2009-08-23 18:28 Marcin Slusarz
2009-08-23 19:43 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2009-08-23 18:28 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, Mike Frysinger, Frederic Weisbecker, Lai Jiangshan
From: Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: vsprintf: use WARN_ON_ONCE
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 756ccaf..a63bb18 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -983,13 +983,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
/* Reject out-of-range values early. Large positive sizes are
used for unknown buffer sizes. */
- if (unlikely((int) size < 0)) {
- /* There can be only one.. */
- static char warn = 1;
- WARN_ON(warn);
- warn = 0;
+ if (WARN_ON_ONCE((int) size < 0))
return 0;
- }
str = buf;
end = buf + size;
@@ -1439,13 +1434,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
struct printf_spec spec = {0};
- if (unlikely((int) size < 0)) {
- /* There can be only one.. */
- static char warn = 1;
- WARN_ON(warn);
- warn = 0;
+ if (WARN_ON_ONCE((int) size < 0))
return 0;
- }
str = buf;
end = buf + size;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH resend] vsprintf: use WARN_ON_ONCE
2009-08-23 18:28 [PATCH resend] vsprintf: use WARN_ON_ONCE Marcin Slusarz
@ 2009-08-23 19:43 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-08-23 19:43 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: Andrew Morton, LKML, Mike Frysinger, Lai Jiangshan
On Sun, Aug 23, 2009 at 08:28:52PM +0200, Marcin Slusarz wrote:
> From: Marcin Slusarz <marcin.slusarz@gmail.com>
> Subject: vsprintf: use WARN_ON_ONCE
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 756ccaf..a63bb18 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -983,13 +983,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
>
> /* Reject out-of-range values early. Large positive sizes are
> used for unknown buffer sizes. */
> - if (unlikely((int) size < 0)) {
> - /* There can be only one.. */
> - static char warn = 1;
> - WARN_ON(warn);
> - warn = 0;
> + if (WARN_ON_ONCE((int) size < 0))
> return 0;
> - }
>
> str = buf;
> end = buf + size;
> @@ -1439,13 +1434,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
>
> struct printf_spec spec = {0};
>
> - if (unlikely((int) size < 0)) {
> - /* There can be only one.. */
> - static char warn = 1;
> - WARN_ON(warn);
> - warn = 0;
> + if (WARN_ON_ONCE((int) size < 0))
> return 0;
> - }
>
> str = buf;
> end = buf + size;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-23 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-23 18:28 [PATCH resend] vsprintf: use WARN_ON_ONCE Marcin Slusarz
2009-08-23 19:43 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox