public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: linux-next: origin tree build warning
Date: Mon, 24 Aug 2009 19:37:41 -0700 (PDT)	[thread overview]
Message-ID: <20090824.193741.139024434.davem@davemloft.net> (raw)
In-Reply-To: <20090825101147.fb929fcb.sfr@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 25 Aug 2009 10:11:47 +1000

> Today's linux-next build (x86_64 allmodconfig, gcc 4.4.0) produced these
> warnings:
> 
> net/sched/sch_api.c: In function 'qdisc_watchdog':
> net/sched/sch_api.c:460: warning: initialization from incompatible pointer type
> net/sched/sch_cbq.c: In function 'cbq_undelay':
> net/sched/sch_cbq.c:595: warning: initialization from incompatible pointer type
> 
> Introduced by commit ee5f9757ea17759e1ce5503bdae2b07e48e32af9
> ("pkt_sched: Convert qdisc_watchdog to tasklet_hrtimer").

Thanks I just committed the following to clean that up.

pkt_sched: Fix bogon in tasklet_hrtimer changes.

Reported by Stephen Rothwell, luckily it's harmless:

net/sched/sch_api.c: In function 'qdisc_watchdog':
net/sched/sch_api.c:460: warning: initialization from incompatible pointer type
net/sched/sch_cbq.c: In function 'cbq_undelay':
net/sched/sch_cbq.c:595: warning: initialization from incompatible pointer type

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/sched/sch_api.c |    2 +-
 net/sched/sch_cbq.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index e1c2bf7..92e6f3a 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -458,7 +458,7 @@ EXPORT_SYMBOL(qdisc_warn_nonwc);
 static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer)
 {
 	struct qdisc_watchdog *wd = container_of(timer, struct qdisc_watchdog,
-						 timer);
+						 timer.timer);
 
 	wd->qdisc->flags &= ~TCQ_F_THROTTLED;
 	__netif_schedule(qdisc_root(wd->qdisc));
diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
index 81652d6..149b040 100644
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -593,7 +593,7 @@ static psched_tdiff_t cbq_undelay_prio(struct cbq_sched_data *q, int prio,
 static enum hrtimer_restart cbq_undelay(struct hrtimer *timer)
 {
 	struct cbq_sched_data *q = container_of(timer, struct cbq_sched_data,
-						delay_timer);
+						delay_timer.timer);
 	struct Qdisc *sch = q->watchdog.qdisc;
 	psched_time_t now;
 	psched_tdiff_t delay = 0;
-- 
1.6.4.1


  reply	other threads:[~2009-08-25  2:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-25  0:11 linux-next: origin tree build warning Stephen Rothwell
2009-08-25  2:37 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-01-27  0:09 Stephen Rothwell
2010-01-18  4:05 Stephen Rothwell
2010-01-18  4:14 ` Stephen Rothwell
2010-01-18  4:29   ` Wu, Fengguang
2010-01-18  5:40     ` Stephen Rothwell
2010-01-19  0:12       ` Stephen Rothwell
2010-01-19 21:05         ` Greg KH
2010-01-19 21:11           ` Greg KH
2010-01-19 23:47             ` Stephen Rothwell
     [not found] <20100101112914.41bc5f77.sfr@canb.auug.org.au>
2010-01-01  0:34 ` Linus Torvalds
2010-01-01  1:02   ` Stephen Rothwell
2010-01-01  1:16     ` Rafael J. Wysocki
2009-12-17  0:10 Stephen Rothwell
2009-12-16  3:52 Stephen Rothwell
2009-12-13 23:24 Stephen Rothwell
2009-12-14  7:24 ` Joe Perches
2009-11-29 23:01 Stephen Rothwell
2009-10-30  3:30 Stephen Rothwell
2009-10-11 23:56 Stephen Rothwell
2009-06-23  0:36 Stephen Rothwell
2009-06-22  1:01 Stephen Rothwell
2009-06-22  3:11 ` FUJITA Tomonori
2009-06-19  1:13 Stephen Rothwell
2009-06-19  8:45 ` Kristoffer Ericson
2009-06-19  0:27 Stephen Rothwell
2009-06-19  0:28 ` Stephen Rothwell
2009-06-11  1:27 Stephen Rothwell
2009-04-29  4:49 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090824.193741.139024434.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox