From: Randy Dunlap <randy.dunlap@oracle.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Rob Landley <rob@landley.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc/rbtree: fix inserting example
Date: Mon, 24 Aug 2009 12:42:39 -0700 [thread overview]
Message-ID: <20090824124239.f7525b97.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4A918BAF.8020600@gmail.com>
On Sun, 23 Aug 2009 20:34:23 +0200 Marcin Slusarz wrote:
> rb_link_node and rb_insert_color take pointer to struct rb_node
> as a first parameter, but example code passes plain struct rb_node.
> Fix it.
This is already corrected in the mainline kernel tree, right?
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Rob Landley <rob@landley.net>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> Documentation/rbtree.txt | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/rbtree.txt b/Documentation/rbtree.txt
> index 7224459..b67a87e 100644
> --- a/Documentation/rbtree.txt
> +++ b/Documentation/rbtree.txt
> @@ -131,8 +131,8 @@ Example:
> }
>
> /* Add new node and rebalance tree. */
> - rb_link_node(data->node, parent, new);
> - rb_insert_color(data->node, root);
> + rb_link_node(&data->node, parent, new);
> + rb_insert_color(&data->node, root);
>
> return TRUE;
> }
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-08-24 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-23 18:34 [PATCH] doc/rbtree: fix inserting example Marcin Slusarz
2009-08-24 19:42 ` Randy Dunlap [this message]
2009-08-25 17:40 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824124239.f7525b97.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox