From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm snapshot: implement .iterate_devices
Date: Mon, 24 Aug 2009 14:15:36 -0700 [thread overview]
Message-ID: <20090824141536.30df105c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1251007867-13004-1-git-send-email-snitzer@redhat.com>
On Sun, 23 Aug 2009 02:11:07 -0400
Mike Snitzer <snitzer@redhat.com> wrote:
> This patch implements .iterate_devices for the origin and snapshot
> targets. dm-snapshot's lack of .iterate_devices resulted in the
> inability to properly establish queue_limits for both targets.
>
> With 4K sector drives: an unfortunate side-effect of not establishing
> proper limits in either targets' DM device was that IO to the devices
> would fail even though both had been created without error.
Does this make the patch a regression fix?
> Commit af4874e03ed82f050d5872d8c39ce64bf16b5c38 should have implemented
> .iterate_devices for dm-snap.c's origin and snapshot targets.
Please use the form af4874e03ed82f050d5872d8c39ce64bf16b5c38 ("dm
target:s introduce iterate devices fn") when referring to commits.
Because commits might have different IDs in different trees (I think
that's the reason).
next prev parent reply other threads:[~2009-08-24 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-23 6:11 [PATCH] dm snapshot: implement .iterate_devices Mike Snitzer
2009-08-24 21:15 ` Andrew Morton [this message]
2009-08-24 22:55 ` Mike Snitzer
2009-08-26 14:50 ` [dm-devel] [PATCH] " Alasdair G Kergon
2009-08-26 18:19 ` Mike Snitzer
2009-08-26 19:32 ` [dm-devel] " Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824141536.30df105c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox