Re: [PATCH 2/4] Add NR_syscalls for x86_64

[Frederic Weisbecker <fweisbec@gmail.com>]

On Mon, Aug 24, 2009 at 05:40:18PM -0400, Jason Baron wrote:
> Add a dynamic definition of NR_syscalls for x86_64. This is used in the 
> syscall events tracing code.
> 
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> 
> ---
>  include/linux/ftrace.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index dc3b132..3bd94ee 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -14,6 +14,11 @@
>  
>  #include <asm/ftrace.h>
>  
> +#ifdef CONFIG_X86_64
> +#include <asm/asm-offsets.h>
> +#define NR_syscalls (__NR_syscall_max + 1)
> +#endif
> +


I'd rather see this in arch/x86/include/unistd_64.h, since
NR_syscalls seems to be the defined in unistd.h in all archs.

That also makes a unified way to retrieve this number for
other users.


>  #ifdef CONFIG_FUNCTION_TRACER
>  
>  extern int ftrace_enabled;
> -- 
> 1.6.2.5
>