Re: [PATCH -tip 1/2] Add "notrace" to RCU function headers used by ftrace.

Mathieu Desnoyers
2009-08-25T00:10:48Z

* Steven Rostedt (rostedt@goodmis.org) wrote:
>
> On Mon, 24 Aug 2009, Paul E. McKenney wrote:
>
> > Both rcu_read_lock_sched_notrace() and rcu_read_unlock_sched_notrace()
> > are used by ftrace, and thus need to be marked "notrace". Unfortunately,
> > my naive assumption that gcc would see the inner "notrace" does not hold.
> > Kudos to Lai Jiangshan for noting this.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > ---
> > include/linux/rcupdate.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> > index ec90fc3..8b4422c 100644
> > --- a/include/linux/rcupdate.h
> > +++ b/include/linux/rcupdate.h
> > @@ -191,7 +191,7 @@ static inline void rcu_read_lock_sched(void)
> > __acquire(RCU_SCHED);
> > rcu_read_acquire();
> > }
> > -static inline void rcu_read_lock_sched_notrace(void)
> > +static inline notrace void rcu_read_lock_sched_notrace(void)
> > {
> > preempt_disable_notrace();
> > __acquire(RCU_SCHED);
> > @@ -209,7 +209,7 @@ static inline void rcu_read_unlock_sched(void)
> > __release(RCU_SCHED);
> > preempt_enable();
> > }
> > -static inline void rcu_read_unlock_sched_notrace(void)
> > +static inline notrace void rcu_read_unlock_sched_notrace(void)
>
> Funny, inlines should not be traced. Is gcc ignoring the inlines here?
>

inline is just a hint. __attribute__((always_inline)) should be used to
really really forbid gcc to generate any function call. So notrace is
needed to make sure we do not trace such function call.

It reminds me of the old mkraid option --really-really-force (or
something like that). ;)

Mathieu

> -- Steve
>
> > {
> > rcu_read_release();
> > __release(RCU_SCHED);
> > --
> > 1.5.2.5
> >
> >

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68