Re: [PATCH -tip 0/2] Temporary RCU fixes for notrace and hotplug CPU

Ingo Molnar
2009-08-25T18:19:49Z

* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> On Tue, Aug 25, 2009 at 08:55:01AM +0200, Ingo Molnar wrote:
> >
> > FYI, -tip testing found a new build warning on SH caused by the RCU
> > tree (i suspect this warning triggers on other architectures as
> > well):
> >
> > /home/mingo/tip/kernel/rcutree.c:88: warning: '__rcu_offline_cpu'
> > declared 'static' but never defined
>
> <red face>
>
> > it's harmless, but since we are generally trying to fix all warnings
> > and gravitate towards more and more -Werror subsystems, it would be
> > nice to fix this.
>
> Indeed, and I have updated my build-output-check script to alert
> me to warning messages from my multiple-configuration test runs.
> Please see below for patch.

btw., you can unset CONFIG_ALLOW_WARNINGS in -tip kernels to turn
build warnings into build failures - and those are harder to miss.

Ingo