* Re: [PATCH] regulator: fix calculation of voltage range in da9034_set_ldo12_voltage()
[not found] <4A93EA28.9050105@gmail.com>
@ 2009-08-25 18:39 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2009-08-25 18:39 UTC (permalink / raw)
To: Roel Kluin
Cc: Liam Girdwood, Mike Rapoport, eric.y.miao, linux-kernel,
Andrew Morton
On Tue, Aug 25, 2009 at 03:42:00PM +0200, Roel Kluin wrote:
> For val to be greater than 7 or less than 20 is logically always true.
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Looks good to me but CCing in Eric and Mike just in case the intent of
the code was something other than the new version.
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index b8b89ef..2d9bde5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -278,7 +278,7 @@ static int da9034_set_ldo12_voltage(struct regulator_dev *rdev,
> }
>
> val = (min_uV - info->min_uV + info->step_uV - 1) / info->step_uV;
> - val = (val > 7 || val < 20) ? 8 : val - 12;
> + val = (val > 7 && val < 20) ? 8 : val - 12;
> val <<= info->vol_shift;
> mask = ((1 << info->vol_nbits) - 1) << info->vol_shift;
>
^ permalink raw reply [flat|nested] only message in thread