Re: [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id

Cyrill Gorcunov
2009-08-25T19:07:31Z

[Yinghai Lu - Tue, Aug 25, 2009 at 11:50:56AM -0700]
...
| > | We should revert to the .30 behavior unless there's a good reason
| > | (even in that case we'll solve the regression and do a workaround
| > | for vSMP). Yinghai?
| > |
| > | Ingo
| >
| > I'm definitely not APIC expert but since I was partially involved
| > letme turn in.
| >
| > Original commit which causes problem for vSMP seems to be due
| > to cpu_has_apic bit turned off (ie due to being manually disabled
| > or acpi table broken) so further read apic id will return plain
| > zero (we're talking about 64 bits now). So frnakly I don't understand
| > what is wrong with Ravikiran's patch. In case of apic disabled
| > initial apic value will be used anyway (which is latched but
| > actually may be changed, but it's not our case).
|
| initial apic id and apic id could be different.

yes, I know. initial one is latched by pins though still
could be changed (not always).

|
| and we should use initial apic id to get correct phys pkg id in case BIOS set crazy apic id.

indeed, as function name implies. Need more code reading...
So (64 bits) at least generic_identify is not guilty since it uses initial
one from scratch. Need more code reading...

|
| YH
|
-- Cyrill