Re: [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id

Ravikiran G Thirumalai
2009-08-25T19:53:49Z

On Tue, Aug 25, 2009 at 09:12:31PM +0200, Ingo Molnar wrote:
>
>* Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
>Furthermore, commit 2759c3287 did not declare any side-effects and
>clearly causes a side-effect on vSMP which apparently has an
>overlapping set of initial APIC ids.
>
>Ravikiran, your patch does not do a clear revert of this bit though.
>If you do a plain revert of the line above alone, does that fix the
>problem too?
>

Yes it does. However, it probably reads local apic id when it shouldn't.

I am right now trying out the other patch Yinghai posted (based on
is_vsmp_box()), and report results in a few.