Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch update

Hendrik Brueckner
2009-08-25T15:38:43Z

On Tue, Aug 25, 2009 at 03:52:32PM +0200, Frederic Weisbecker wrote:
> On Tue, Aug 25, 2009 at 02:31:11PM +0200, Hendrik Brueckner wrote:
> > This patch includes s390 arch updates for:
> > - tracing: Map syscall name to number (syscall_name_to_nr())
> > - tracing: Call arch_init_ftrace_syscalls at boot
> > - tracing: add support traceopint ids (set_syscall_{enter,exit}_id())
> >
> > The patch already uses "NR_syscalls" instead of FTRACE_SYSCALL_MAX.
> >
> > The patch is based on today's linux-next (20090825).
> > Since few of your patches already include s390 changes,
> > I would appreciate if you could add the patch to your patch set.
> >
> > If you have any remarks, please let me know.
> >
> > Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
>
>
> Looks good at a first glance.
Thanks

> > +int syscall_name_to_nr(char *name)
> > +{
> > + int i;
> > +
> > + if (!syscalls_metadata)
> > + return -1;
> > + for (i = 0; i < NR_syscalls; i++)
> > + if (syscalls_metadata[i])
> > + if (!strcmp(syscalls_metadata[i]->name, name))
> > + return i;
> > + return -1;
> > +}
> > +void set_syscall_enter_id(int num, int id)
> > +{
> > + syscalls_metadata[num]->enter_id = id;
> > +}
> > +
> > +void set_syscall_exit_id(int num, int id)
> > +{
> > + syscalls_metadata[num]->exit_id = id;
> > +}
>
> The three helpers above seem very common between archs, I guess
> we can move them to the core: kernel/trace/trace_syscalls.c
I think it is a good idea to move the helper routines to
kernel/trace/trace_syscalls.c.