From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932458AbZHZLcW (ORCPT ); Wed, 26 Aug 2009 07:32:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757298AbZHZLcV (ORCPT ); Wed, 26 Aug 2009 07:32:21 -0400 Received: from e28smtp01.in.ibm.com ([59.145.155.1]:44896 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757118AbZHZLcV (ORCPT ); Wed, 26 Aug 2009 07:32:21 -0400 Date: Wed, 26 Aug 2009 17:02:17 +0530 From: Arun R Bharadwaj To: Peter Zijlstra Cc: Joel Schopp , Benjamin Herrenschmidt , Paul Mackerras , Ingo Molnar , Vaidyanathan Srinivasan , Dipankar Sarma , Balbir Singh , Gautham R Shenoy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Arun Bharadwaj Subject: Re: [v2 PATCH 2/2]: pseries: Implement Pseries Processor Idle idle module. Message-ID: <20090826113217.GA14758@linux.vnet.ibm.com> Reply-To: arun@linux.vnet.ibm.com References: <20090826110721.GA29759@linux.vnet.ibm.com> <20090826111003.GC29759@linux.vnet.ibm.com> <1251286038.1329.1.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1251286038.1329.1.camel@twins> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra [2009-08-26 13:27:18]: > On Wed, 2009-08-26 at 16:40 +0530, Arun R Bharadwaj wrote: > > +void (*pm_idle)(void); > > +EXPORT_SYMBOL_GPL(pm_idle); > > Seriously.. this caused plenty problems over on x86 and you're doing the > exact same dumb thing? > Hi Peter, Cpuidle assumes pm_idle to be the default idle power management function. So i should either do this, or change the stuff in cpuidle.c so that it is more abstract. --arun