From: Frederic Weisbecker <fweisbec@gmail.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
lethal@linux-sh.org, mingo@elte.hu, laijs@cn.fujitsu.com,
peterz@infradead.org, mathieu.desnoyers@polymtl.ca,
jiayingz@google.com, mbligh@google.com, lizf@cn.fujitsu.com,
jistone@redhat.com, tglx@linutronix.de, hpa@zytor.com
Subject: Re: [PATCH 2/4] Add NR_syscalls for x86_64
Date: Wed, 26 Aug 2009 18:24:18 +0200 [thread overview]
Message-ID: <20090826162412.GA6759@nowhere> (raw)
In-Reply-To: <20090826160910.GB2658@redhat.com>
On Wed, Aug 26, 2009 at 12:09:10PM -0400, Jason Baron wrote:
> doesn't quite work, b/c the top of asm-offsets_64.c has a bunch of
> includes, such as: <linux/sched.h>, which in turn include unistd.h at
> a point in time where asm/asm-offests.h does not exist.
>
> However, a much simpler version of the previous patch I posted does do
> the trick, below. I hope this version is more palatable?
>
> thanks,
>
> -Jason
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
Ah yeah, looks good!
>
> diff --git a/arch/x86/include/asm/unistd_64.h b/arch/x86/include/asm/unistd_64.h
> index 900e161..b9f3c60 100644
> --- a/arch/x86/include/asm/unistd_64.h
> +++ b/arch/x86/include/asm/unistd_64.h
> @@ -688,6 +688,12 @@ __SYSCALL(__NR_perf_counter_open, sys_perf_counter_open)
> #endif /* __NO_STUBS */
>
> #ifdef __KERNEL__
> +
> +#ifndef COMPILE_OFFSETS
> +#include <asm/asm-offsets.h>
> +#define NR_syscalls (__NR_syscall_max + 1)
> +#endif
> +
> /*
> * "Conditional" syscalls
> *
> diff --git a/arch/x86/kernel/asm-offsets_64.c b/arch/x86/kernel/asm-offsets_64.c
> index 898ecc4..4a6aeed 100644
> --- a/arch/x86/kernel/asm-offsets_64.c
> +++ b/arch/x86/kernel/asm-offsets_64.c
> @@ -3,6 +3,7 @@
> * This code generates raw asm output which is post-processed to extract
> * and format the required data.
> */
> +#define COMPILE_OFFSETS
>
> #include <linux/crypto.h>
> #include <linux/sched.h>
next prev parent reply other threads:[~2009-08-26 16:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 21:40 [PATCH 0/4] use NR_syscalls instead of FTRACE_SYSCALL_MAX Jason Baron
2009-08-24 21:40 ` [PATCH 1/4] add NR_syscalls define for x86 Jason Baron
2009-08-24 22:05 ` Paul Mundt
2009-08-25 13:37 ` Jason Baron
2009-08-28 12:28 ` [tip:tracing/core] tracing: Define NR_syscalls for x86 (32) tip-bot for Jason Baron
2009-08-24 21:40 ` [PATCH 2/4] Add NR_syscalls for x86_64 Jason Baron
2009-08-24 22:14 ` Frederic Weisbecker
2009-08-24 22:44 ` Steven Rostedt
2009-08-25 13:40 ` Jason Baron
2009-08-25 18:47 ` Jason Baron
2009-08-25 19:04 ` Mathieu Desnoyers
2009-08-25 20:58 ` Jason Baron
2009-08-25 23:28 ` Mathieu Desnoyers
2009-08-25 23:38 ` Frederic Weisbecker
2009-08-26 2:25 ` Steven Rostedt
2009-08-26 13:58 ` Jason Baron
2009-08-26 14:39 ` Steven Rostedt
2009-08-26 16:09 ` Jason Baron
2009-08-26 16:21 ` Steven Rostedt
2009-08-26 16:29 ` Frederic Weisbecker
2009-08-26 16:24 ` Frederic Weisbecker [this message]
2009-08-28 12:28 ` [tip:tracing/core] tracing: Define " tip-bot for Jason Baron
2009-08-24 21:40 ` [PATCH 3/4] Convert event tracing code to NR_syscalls Jason Baron
2009-08-28 12:28 ` [tip:tracing/core] tracing: Convert event tracing code to use NR_syscalls tip-bot for Jason Baron
2009-08-24 21:40 ` [PATCH 4/4] remove FTRACE_SYSCALL_MAX definitions Jason Baron
2009-08-28 12:28 ` [tip:tracing/core] tracing: Remove " tip-bot for Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826162412.GA6759@nowhere \
--to=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=jistone@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).