Re: [Intel-gfx] [PATCH] Samsung laptop driver

[Greg KH <greg@kroah.com>]

On Sat, Aug 22, 2009 at 12:07:01PM +0200, Bruno Prémont wrote:
> On Fri, 21 August 2009 Greg KH <greg@kroah.com> wrote:
> > From: Greg Kroah-Hartman <gregkh@suse.de>
> > Subject: Samsung laptop driver
> > 
> > This driver implements backlight controls for Samsung laptops that
> > currently do not have ACPI support for this control.
> > 
> > It has been tested on the N130 laptop and properly works there.
> > 
> > Many thanks to Dmitry Torokhov <dmitry.torokhov@gmail.com> for
> > cleanups and other suggestions on how to make the driver simpler.
> 
> Hm, that one fails to compile here:
>   CC [M]  drivers/platform/x86/samsung-laptop.o
> /usr/src/linux-2.6/drivers/platform/x86/samsung-laptop.c: In function 'sabi_get_command':
> /usr/src/linux-2.6/drivers/platform/x86/samsung-laptop.c:141: error: implicit declaration of function 'msleep'
> make[5]: *** [drivers/platform/x86/samsung-laptop.o] Error 1
> make[4]: *** [drivers/platform/x86] Error 2
> make[3]: *** [drivers/platform] Error 2
> make[2]: *** [drivers] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> Missing a #include <linux/delay.h>?

Yes, I've added it now, thanks.

greg k-h