public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pierre Habouzit <pierre.habouzit@intersec.com>
Cc: Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: do not complain if root is owning perf.data
Date: Wed, 26 Aug 2009 20:24:59 +0200	[thread overview]
Message-ID: <20090826182459.GD13632@elte.hu> (raw)
In-Reply-To: <1251291926-27174-1-git-send-email-pierre.habouzit@intersec.com>


* Pierre Habouzit <pierre.habouzit@intersec.com> wrote:

> This improves patch fa6963b24 so that perf.data stuff that has 
> been dumped as root can be read (annotate/report) by a user 
> without the use of the --force.
> 
> Rationale is that root has plenty of ways to screw us (usually) 
> that do not require twisted schemes involving specially crafting a 
> perf.data.
> 
> Signed-off-by: Pierre Habouzit <pierre.habouzit@intersec.com>
> ---
>  tools/perf/builtin-annotate.c |    4 ++--
>  tools/perf/builtin-report.c   |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Ok, this makes sense - but i think we should do this in .32 only, 
with a Cc: <stable@kernel.org> backport tag for .31.1.

Mind doing it against the latest perfcounters tree, which can be 
found in -tip:

  http://people.redhat.com/mingo/tip.git/README

your current version does not apply cleanly as the surrounding code 
has changed a bit already.

Thanks,

	Ingo

  reply	other threads:[~2009-08-26 18:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 13:05 [PATCH] perf tools: do not complain if root is owning perf.data Pierre Habouzit
2009-08-26 18:24 ` Ingo Molnar [this message]
2009-08-27  7:59   ` [PATCH v2] " Pierre Habouzit
2009-08-28 11:49     ` Ingo Molnar
2009-08-28 11:52     ` [tip:perfcounters/core] " tip-bot for Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090826182459.GD13632@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=pierre.habouzit@intersec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox