From: Pierre Habouzit <pierre.habouzit@intersec.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: [PATCH v2] perf tools: do not complain if root is owning perf.data
Date: Thu, 27 Aug 2009 09:59:02 +0200 [thread overview]
Message-ID: <20090827075902.GF19653@laphroaig.corp> (raw)
In-Reply-To: <20090826182459.GD13632@elte.hu>
This improves patch fa6963b24 so that perf.data stuff that has been dumped
as root can be read (annotate/report) by a user without the use of the
--force.
Rationale is that root has plenty of ways to screw us (usually) that do
not require twisted schemes involving specially crafting a perf.data.
Signed-off-by: Pierre Habouzit <pierre.habouzit@intersec.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>,
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Cc: <stable@kernel.org>
---
On Wed, Aug 26, 2009 at 08:24:59PM +0200, Ingo Molnar wrote:
> Ok, this makes sense - but i think we should do this in .32 only,
> with a Cc: <stable@kernel.org> backport tag for .31.1.
You're the boss ;)
> Mind doing it against the latest perfcounters tree, which can be
> found in -tip:
>
> http://people.redhat.com/mingo/tip.git/README
>
> your current version does not apply cleanly as the surrounding code
> has changed a bit already.
Here it is, against perfcounters/core which I assume is the proper
tip branch. Note that I'd suggest adding a README.Devel under
tools/perf to explicit how patches should be submitted, at least to
explain against which tree it's best to do our patches for
submission, it could help people avoiding losing your time with
unnecessary back-and-forth mails just to rebase a patch ;)
tools/perf/builtin-annotate.c | 4 ++--
tools/perf/builtin-report.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 4ac618b..4c7bc44 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -984,8 +984,8 @@ static int __cmd_annotate(void)
exit(-1);
}
- if (!force && (input_stat.st_uid != geteuid())) {
- fprintf(stderr, "file: %s not owned by current user\n", input_name);
+ if (!force && input_stat.st_uid && (input_stat.st_uid != geteuid())) {
+ fprintf(stderr, "file: %s not owned by current user or root\n", input_name);
exit(-1);
}
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index d2e2882..ea6328a 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1405,8 +1405,8 @@ static int __cmd_report(void)
exit(-1);
}
- if (!force && (input_stat.st_uid != geteuid())) {
- fprintf(stderr, "file: %s not owned by current user\n", input_name);
+ if (!force && input_stat.st_uid && (input_stat.st_uid != geteuid())) {
+ fprintf(stderr, "file: %s not owned by current user or root\n", input_name);
exit(-1);
}
--
1.6.4.1.341.gf2a44
next prev parent reply other threads:[~2009-08-27 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 13:05 [PATCH] perf tools: do not complain if root is owning perf.data Pierre Habouzit
2009-08-26 18:24 ` Ingo Molnar
2009-08-27 7:59 ` Pierre Habouzit [this message]
2009-08-28 11:49 ` [PATCH v2] " Ingo Molnar
2009-08-28 11:52 ` [tip:perfcounters/core] " tip-bot for Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090827075902.GF19653@laphroaig.corp \
--to=pierre.habouzit@intersec.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox