Re: [PATCH -tip tracing/kprobes 3/6] kprobes/x86: Fix to add __kprobes to in-kernel fault handing functions

Masami Hiramatsu
2009-09-04T22:26:22Z

Frederic Weisbecker wrote:
> On Wed, Sep 02, 2009 at 08:58:05AM -0400, Masami Hiramatsu wrote:
>> Frederic Weisbecker wrote:
>>> BTW, after your patchset:
>>>
>>> TEST posttest
>>> Building modules, stage 2.
>>> Error: c0101038: 2e a1 f8 b0 9e c0 mov %cs:0xc09eb0f8,%eax
>>> Error: objdump says 6 bytes, but insn_get_length() says 10 (attr:40000)
>>> make[1]: *** [posttest] Erreur 2
>>> make: *** [bzImage] Erreur 2
>>> make: *** Attente des tâches non terminées....
>>> MODPOST 4 modules
>>>
>>>
>>> I'm cross compiling from 64 to 32 using:
>>>
>>> make ARCH=x86
>>>
>>> I've attached my config.
>>
>> Aah, you might miss an important patch :D
>> http://lkml.org/lkml/2009/8/28/367
>>
>> Thank you,
>>
>
>
> Well, even with this patch I have this problem occuring with
> make ARCH=x86
>
> Error: c125d65d: 0f 6f 02 movq (%edx),%mm0
> Error: objdump says 3 bytes, but insn_get_length() says 2 (attr:0)
> make[1]: *** [posttest] Erreur 2
> make: *** [bzImage] Erreur 2
>
> Hmm, may be that's because it doesn't support mmx instructions.
> The whole patchset is on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> tracing/kprobes
>
> Config and make V=1 log attached.

Aah, Indeed. It's time to add MMX/SSE support on x86 insn decoder.

Thank you for reporting!

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com