public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Tom Zanussi <tzanussi@gmail.com>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/filters: Defer pred allocation
Date: Mon, 31 Aug 2009 10:59:08 +0200	[thread overview]
Message-ID: <20090831085908.GA656@elte.hu> (raw)
In-Reply-To: <4A9B8EA5.6020700@cn.fujitsu.com>


* Li Zefan <lizf@cn.fujitsu.com> wrote:

> init_preds() allocates about 5392 bytes of memory (on x86_32) for
> a TRACE_EVENT. With my config, at system boot total memory occupied
> is:
> 
> 	5392 * (642 + 15) == 3459KB
> 
> 642 == cat available_events | wc -l
> 15 == number of dirs in events/ftrace
> 
> That's quite a lot, so we'd better defer memory allocation util
> it's needed, that's when filter is used.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Applied, thanks!

> tracing/kprobe needs rebase after this patch..

You mean with many probes registered it has a lot of memory 
footprint? Instead of a rebase a merge of tracing/core into 
tracing/kprobes would be less intrusive.

	Ingo

  reply	other threads:[~2009-08-31  8:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31  8:49 [PATCH] tracing/filters: Defer pred allocation Li Zefan
2009-08-31  8:59 ` Ingo Molnar [this message]
2009-08-31  9:06   ` Li Zefan
2009-09-01 12:58     ` Masami Hiramatsu
2009-08-31  9:00 ` [tip:tracing/core] " tip-bot for Li Zefan
2009-08-31 17:41 ` [PATCH] " Frederic Weisbecker
2009-09-01  0:50   ` Li Zefan
2009-09-01  5:31   ` [PATCH] tracing/filters: Defer pred allocation, fix memory leak Li Zefan
2009-09-01  9:32     ` Frederic Weisbecker
2009-09-06  4:36     ` [tip:tracing/core] " tip-bot for Li Zefan
2009-09-01  3:28 ` [PATCH] tracing/filters: Defer pred allocation Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090831085908.GA656@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mhiramat@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox