From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755177AbZIAQdu (ORCPT ); Tue, 1 Sep 2009 12:33:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755165AbZIAQdt (ORCPT ); Tue, 1 Sep 2009 12:33:49 -0400 Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:41524 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755123AbZIAQds (ORCPT ); Tue, 1 Sep 2009 12:33:48 -0400 From: Dmitry Torokhov Organization: VMware, Inc. To: Matthew Wilcox Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA. Date: Tue, 1 Sep 2009 09:33:50 -0700 User-Agent: KMail/1.12.0 (Linux/2.6.31-rc8; KDE/4.3.0; x86_64; ; ) Cc: Roland Dreier , Bart Van Assche , James Bottomley , Alok Kataria , Robert Love , Randy Dunlap , Mike Christie , "linux-scsi@vger.kernel.org" , LKML , Andrew Morton , Rolf Eike Beer , Maxime Austruy References: <1251415060.16297.58.camel@ank32.eng.vmware.com> <20090901161651.GO22870@parisc-linux.org> In-Reply-To: <20090901161651.GO22870@parisc-linux.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200909010933.50571.dtor@vmware.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 September 2009 09:16:51 am Matthew Wilcox wrote: > On Tue, Sep 01, 2009 at 09:12:43AM -0700, Roland Dreier wrote: > > I'm not really sure we should be trying to force drivers to share just > > because they are paravirtualized -- if there is real commonality, then > > sure put it in common code, but different hypervisors are probably as > > different as different hardware. > > I really disagree. This kind of virtualised drivers are pretty much > communication protocols, and not hardware. As such, why design a new one? > If there's an infelicity in the ibmvscsi protocol, it makes sense to > design a new one. But being different for the sake of being different > is just a way to generate a huge amount of make-work. > The same thing can be said about pretty much anything. We don't have single SCSI, network, etc driver handling every devices in their respective class, I don't see why it would be different here. A hypervisor presents the same interface to the guest OS (whether it is Linux, Solaris or another OS) much like a piece of silicone does and it may very well be different form other hypervisors. -- Dmitry