From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH V6 1/2] introduce ALS sysfs class
Date: Tue, 1 Sep 2009 15:41:44 +0200 [thread overview]
Message-ID: <20090901134144.GA2028@ucw.cz> (raw)
In-Reply-To: <200909012047.00606.rjw@sisk.pl>
> > > IMO, 0 and -1 are not errors. they just suggest that the Ambient Light
> > > illuminance is beyond the device support range, while the device is
> > > still working normally.
> > > what about exporting these values (0 and -1) to user space directly?
> >
> > Returning 0 for "below" range and 99999999 for "above" range would be
> > nice, yes.
>
> Why not 0 and "all ones" or 0 and -1.
>
> Is there anything wrong with -1 in particular?
Normal people expect -1 to be less than 123, and output is in ascii. If
you make it ((unsigned) ~0) I guess that becomes acceptable.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-09-01 20:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 7:25 [PATCH V6 1/2] introduce ALS sysfs class Zhang Rui
2009-09-01 8:11 ` Pavel Machek
2009-09-01 8:30 ` Zhang Rui
2009-09-01 8:43 ` Pavel Machek
2009-09-01 18:47 ` Rafael J. Wysocki
2009-09-01 13:41 ` Pavel Machek [this message]
2009-09-02 21:12 ` Rafael J. Wysocki
2009-09-02 21:14 ` Pavel Machek
2009-09-02 21:46 ` Rafael J. Wysocki
2009-09-02 21:51 ` Pavel Machek
2009-09-03 0:16 ` Rafael J. Wysocki
2009-09-03 2:35 ` Zhang Rui
2009-09-03 8:45 ` Pavel Machek
2009-09-03 21:13 ` Rafael J. Wysocki
2009-09-03 8:43 ` Pavel Machek
2009-09-03 21:10 ` Rafael J. Wysocki
2009-09-02 19:22 ` Alan Jenkins
2009-09-03 2:45 ` Zhang Rui
2009-09-03 8:35 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901134144.GA2028@ucw.cz \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox