From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, dg@emlix.com
Subject: Re: [patch 2.6.31-rc7] gpiolib: allow poll() on value
Date: Tue, 1 Sep 2009 18:04:10 -0700 [thread overview]
Message-ID: <200909011804.10934.david-b@pacbell.net> (raw)
In-Reply-To: <20090901134311.95fba3c8.akpm@linux-foundation.org>
On Tuesday 01 September 2009, Andrew Morton wrote:
> > ...
> >
> > +static struct idr pdesc_idr;
>
> There's no locking to protect this tree. If that isn't a bug then I'd
> suggest that a comment be added here explaining why.
Covered by mutex_lock(&sysfs_lock) calls per a quick re-read...
> > +static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
> > +{
> > + struct work_struct *work = priv;
> > +
> > + schedule_work(work);
> > + return IRQ_HANDLED;
> > +}
>
> The only place where we explicitly cancel the pending work is in
> gpio_setup_irq(). Is that sufficient? Is there any way in which the
> work callback can occur after things have been
> freed/closed/deinitialised/etc?
Not that I noticed; it's not supposed to be possible to
free/etc with IRQs active.
- Dave
prev parent reply other threads:[~2009-09-02 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 23:50 [patch 2.6.31-rc7] gpiolib: allow poll() on value David Brownell
2009-09-01 20:43 ` Andrew Morton
2009-09-02 1:04 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909011804.10934.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=dg@emlix.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox