From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] tracing: make splice_read work when data is sufficient
Date: Wed, 2 Sep 2009 00:37:01 +0200 [thread overview]
Message-ID: <20090901223659.GB6108@nowhere> (raw)
In-Reply-To: <4A9D13C1.4030902@cn.fujitsu.com>
On Tue, Sep 01, 2009 at 08:29:53PM +0800, Lai Jiangshan wrote:
> Frederic Weisbecker wrote:
> >> */
> >> + cpu_buffer->reader_page->read = 0;
> >
> >
> >
> > Wasn't this reset done before?
> >
> >
>
> This is not reset. It is still used just before this line.
Yeah but after that it's not used anymore because this page
won't anymore be used as a reader page but will be integrated
as a writable ring buffer page.
One day it may be reused as a reader page still, but before
any use, rb_reset_reader_page() will be called to reset this offset.
So I just don't understand why you need to do that.
> >
> >
> > Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
> >
> >
>
> Ingo, Could you apply this patch and fix the bug?
>
next prev parent reply other threads:[~2009-09-01 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 3:02 [PATCH 1/3] tracing: make splice_read work when data is sufficient Lai Jiangshan
2009-08-29 9:45 ` Frederic Weisbecker
2009-09-01 12:29 ` Lai Jiangshan
2009-09-01 22:37 ` Frederic Weisbecker [this message]
2009-09-02 7:37 ` Lai Jiangshan
2009-09-09 20:51 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901223659.GB6108@nowhere \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox