From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] tracing: block-able ring_buffer consumer
Date: Wed, 2 Sep 2009 01:12:00 +0200 [thread overview]
Message-ID: <20090901231200.GD6108@nowhere> (raw)
In-Reply-To: <20090901230508.GC6108@nowhere>
On Wed, Sep 02, 2009 at 01:05:10AM +0200, Frederic Weisbecker wrote:
> void poll_wait_pipe(struct trace_iterator *iter)
> {
> set_current_state(TASK_INTERRUPTIBLE);
> /* sleep for 100 msecs, and try again. */
> schedule_timeout(HZ / 10);
> }
>
> On the worst case the reader will wait for 1/100 secs
> (the comment is wrong).
No the comment is not wrong. It's just that I really suck in math :-)
>
> You can probably use the same thing for ring buffer splice
> and poll waiters.
>
> Frederic.
>
next prev parent reply other threads:[~2009-09-01 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 3:03 [PATCH 2/3] tracing: block-able ring_buffer consumer Lai Jiangshan
2009-08-29 10:21 ` Frederic Weisbecker
2009-09-01 12:53 ` Lai Jiangshan
2009-09-01 23:05 ` Frederic Weisbecker
2009-09-01 23:12 ` Frederic Weisbecker [this message]
2009-09-09 21:10 ` Steven Rostedt
2009-09-10 2:06 ` Frederic Weisbecker
2009-09-09 21:06 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901231200.GD6108@nowhere \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox