From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 1/2] AB3100 regulator support v3
Date: Wed, 2 Sep 2009 18:24:38 +0100 [thread overview]
Message-ID: <20090902172438.GA1190@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1251756258-23917-1-git-send-email-linus.walleij@stericsson.com>
On Tue, Sep 01, 2009 at 12:04:18AM +0200, Linus Walleij wrote:
> This adds support for the regulators found in the AB3100
> Mixed-Signal IC.
>
> It further also defines platform data for the ST-Ericsson
> U300 platform and extends the AB3100 MFD driver so that
> platform/board data with regulation constraints and an init
> function can be passed down all the way from the board to
> the regulators.
>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
This looks basically good - my only concern is if the initialisation
data supplied for the regulators is just setting up the things that can
be set up via the API or if there's other stuff going on (this was my
reason for the question I asked the other day). If there's other stuff
being configured then I'm happy with the patch modulo the static thing.
next prev parent reply other threads:[~2009-09-02 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 22:04 [PATCH 1/2] AB3100 regulator support v3 Linus Walleij
2009-09-02 17:24 ` Mark Brown [this message]
2009-09-02 21:37 ` Linus Walleij
2009-09-02 21:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902172438.GA1190@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).